Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - BUG | Unit Notes / Cancel (Person Giving Notice) #18373

Closed
LizGovier opened this issue Oct 28, 2023 · 7 comments
Closed

UI - BUG | Unit Notes / Cancel (Person Giving Notice) #18373

LizGovier opened this issue Oct 28, 2023 · 7 comments
Assignees
Labels
Assets bug Something isn't working UX Assurance

Comments

@LizGovier
Copy link
Collaborator

LizGovier commented Oct 28, 2023

When I cancel a NPUB (Public Note), NCON Confidential Note:

  • Person Giving Notice should be optional and have the checkmark beside it
  • the person giving notice information should carry forward from the original filing. Ex: If the checkbox was selected when a Public Note was file, it show as selected when cancelling.

See Designs:
https://www.figma.com/file/FVvx7KgHDCAfejklfoue3L/MHR---Unit-Notes?type=design&node-id=1792-43093&mode=design

Error (DEV)
Private Zenhub Image

@LizGovier LizGovier added bug Something isn't working Assets UX Assurance labels Oct 28, 2023
@LizGovier LizGovier changed the title UI - Unit Notes / Cancel UI - BUG | Unit Notes / Cancel (Person Giving Notice) Oct 28, 2023
@PCC199 PCC199 changed the title UI - BUG | Unit Notes / Cancel (Person Giving Notice) Verify - UI - BUG | Unit Notes / Cancel (Person Giving Notice) Nov 24, 2023
@chdivyareddy
Copy link
Collaborator

chdivyareddy commented Jul 8, 2024

Hey @arlentees , from the description mentioned above for the cancel unit note, the checkmark should be auto-selected for the person giving notice when the initial unit note person giving notice checkmark was checked and also noted that the Attention field value is being retained from the initial unit note filing to the cancel unit note. So, moving this back to product backlog for now, thanks!
cc @LizGovier

MHR 108170 in TEST:

  • Public Note:

image.png

Cancel Public Note: If the checkbox was selected when a Public Note was filed, then it should show as selected when cancelling.

image.png

  • Attention value is retained from the initial public note filing:

image.png

  • Confidential Note:

image.png

  • Cancel Confidential Note: If the checkbox was selected when the Confidential Note was filed, then it should show as selected when cancelling.

image.png

  • Attention value is retained from the initial confidential note filing:

image.png

@chdivyareddy chdivyareddy removed their assignment Jul 8, 2024
@arlentees
Copy link
Collaborator

Thanks @chdivyareddy ! I took a look at he figma file and there might be a difference between what's in the design and what's described here in this ticket. @LizGovier can you weigh in?

@LizGovier
Copy link
Collaborator Author

@arlentees
It looks like the values for NPUB, NCON, and 103 are not being carried over when being cancelled, meaning if 'There was no person giving notice' was selected on the initial registration, it should be carried over when cancelling the note. Also, the Attention value is not supposed to retain the initial confidential note filing. So these two things will need to be fixed.

@HimaniTanwarGov HimaniTanwarGov changed the title Verify - UI - BUG | Unit Notes / Cancel (Person Giving Notice) UI - BUG | Unit Notes / Cancel (Person Giving Notice) Jul 10, 2024
@flutistar flutistar self-assigned this Jul 11, 2024
@LizGovier LizGovier reopened this Jul 12, 2024
@chdivyareddy
Copy link
Collaborator

Hey @flutistar Brandon, everything looks great...just a minor fix for the Attention value field for notice of redemption (other cancel notes attention fields works as expected). When a Notice of tax sale is cancelled (Notice is redemption), the Attention value is retained from the Notice of Tax Sale filing. Can you please take a look, thanks!

MHR 108170 in TEST.
Steps to reproduce:

  • File a Notice of tax sale unit note (enter the attention value)
  • Now, file Notice of Redemption
  • Navigate to the review screen, attention field value is pre-populated

image.png

image.png

@flutistar
Copy link
Collaborator

Yep I will fix it.

@LizGovier
Copy link
Collaborator Author

Looks good!
MHR 108356 - In DEV
When filing a Notice of Tax Sale and adding 'Attention to:', the attention field is blank upon filing a noticed of redemption.

RFQA

@chdivyareddy
Copy link
Collaborator

Verified in DEV!

MHR 108334:

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assets bug Something isn't working UX Assurance
Projects
None yet
Development

No branches or pull requests

5 participants