Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display 'N/A' in Days to Expiry column for CAUC unit note in the MHR table #18443

Closed
1 task
chdivyareddy opened this issue Nov 2, 2023 · 8 comments
Closed
1 task
Assignees
Labels
Assets bug Something isn't working

Comments

@chdivyareddy
Copy link
Collaborator

  • When a user selects 'Continued until further order of the court.' for Continued Notice of Caution note, then the expiry date should display as 'N/A' in the MHR table instead of '-9999 days'

MHR 107229 in TEST:

Private Zenhub Image

Design:
Private Zenhub Image

@chdivyareddy chdivyareddy added Assets bug Something isn't working labels Nov 2, 2023
@mstanton1
Copy link
Collaborator

9999 is the API pattern for an infinite term.

@dimak1
Copy link
Collaborator

dimak1 commented Jun 17, 2024

This was fixed sometime ago in PR #1655. I checked MHR 108309, and 'N/A' is showing.

Screenshot 2024-06-17 at 05.41.35.png

@chdivyareddy
Copy link
Collaborator Author

Hey @dimak1 , I just verified in DEV and noticed that 'N/A' is displayed in the unit notes section but in the MHR table it displays as "27 years 138 days"

MHR 108355:
image.png

image.png

@chdivyareddy chdivyareddy assigned dimak1 and unassigned chdivyareddy Jun 17, 2024
@dimak1
Copy link
Collaborator

dimak1 commented Jun 17, 2024

@chdivyareddy I just checked the payload it is '9999' instead of '-9999'.

Screenshot 2024-06-17 at 15.53.30.png

@doug-lovett could you please take a look.

@doug-lovett
Copy link
Collaborator

@dimak1 @chdivyareddy sorry Dima, the first comment from Melissa is correct, the ticket description is wrong. The value 9999 indicates no expiry. Here is the API spec description for expireDays:
Conditionally included for the CAU, CAUC, and CAUE caution document types. The value may be negative, and represents the number of days from the current timestamp before a caution unit note registration expires. For a CAUC document type with no expiry date, an unreachable value of 9999 is returned. If the caution registration has been cancelled an unreachable value of -9999 is returned.

@doug-lovett doug-lovett removed their assignment Jun 18, 2024
@dimak1
Copy link
Collaborator

dimak1 commented Jun 18, 2024

Thanks @doug-lovett
So both, 9999 and -9999 should show 'N/A' ? @LizGovier

@dimak1 dimak1 removed their assignment Jun 18, 2024
@LizGovier
Copy link
Collaborator

Hey @dimak1 Here is a bit more context for the CAUC expiry date.
Screen Shot 2024-06-18 at 8.32.51 AM.png

@chdivyareddy
Copy link
Collaborator Author

Verified in DEV!

MHR 108354:
image.png

image.png

Search output:
2024-06-24_BCMHR_Search_Result_108354_15210.pdf

@PCC199 PCC199 closed this as completed Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assets bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants