Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location Type for legacy home does not display when staff OPEN registration in modernized app #18447

Closed
catherinecarlson opened this issue Nov 2, 2023 · 7 comments
Assignees
Labels
Assets bug Something isn't working

Comments

@catherinecarlson
Copy link

catherinecarlson commented Nov 2, 2023

I created MH 107274 in BCOL and MH 107277 in modernized application.

Location type and civic address display for home MH 107274 in BCOL search output:

Developer Note:
Update the API to derive the location type and include it in the API response for legacy registrations.

Private Zenhub Image

Location type does not display in modernized app when I open it in the staff list. Civic address displays. Plus I believe that 'Park Name' should display instead of Dealer/Manufacturer.

Private Zenhub Image

The Location type displays correctly in the modernized search PDF output:

Private Zenhub Image

@catherinecarlson catherinecarlson changed the title Location Type for legacy home does not display when staff OPEN registration Location Type for legacy home does not display when staff OPEN registration in modernized app Nov 2, 2023
@catherinecarlson
Copy link
Author

I created MH 107277 in modernized application.

Location type and civic address display for home MH 107277 in modernized staff list:

Private Zenhub Image

The Location type displays correctly in the modernized search PDF output and BCOL search output.

@mstanton1
Copy link
Collaborator

This could be tackled through an API change. For data migration we have logic we use to check, otherwise set location type to other.

@doug-lovett
Copy link
Collaborator

@chdivyareddy you may have to test this in TEST as DEV PostgreSQL has migrated data with location types.

@chdivyareddy
Copy link
Collaborator

@doug-lovett , thanks for the heads up!

@chdivyareddy
Copy link
Collaborator

Hey @doug-lovett , the above example (MH 107274) now displays as expected in the modernized application. But, for MH 107186 & 107187 in TEST (Location type - Indian Reserve), "Legal Land Description" displayed as 'Not entered' in the Transfer (UI) when user clicks on Open button, where as in the search outputs it displays as follows...please take a look, thanks!!

MH 107186:
MHR info screen:
Private Zenhub Image

Search Output:
Private Zenhub Image

@doug-lovett
Copy link
Collaborator

@chdivyareddy this change is just to display the location type. The legacy database does not capture the LTSA legal description for a PID. For search, the API is looking up the LTSA legal description if a PID exists. The API is not doing this for a legacy home current view.

@chdivyareddy
Copy link
Collaborator

@doug-lovett , thank you!! Will move this ticket to Done for now as the location type is displayed as expected.

MHR 107274 in TEST

Private Zenhub Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assets bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants