AGM Location Change PDF file name - "AGM" should be in all caps

[yuisotozaki]

AGM Location Change PDF file name - "AGM" should be in all caps

Private Zenhub Image

[severinbeauvais]

This issue will also affect the Letter Of AGM Extension Change.

[severinbeauvais]

The root cause of this issue is that the UI generates the name from the document's key, ie:

Private Zenhub Image

In this example, letterOfAgmLocationChange becomes "Letter Of Agm Location Change".

To solve this will require the Legal API to pass the "name" as well as (or instead of) the key value. Note that this may affect third party users. Also, Filings UI will need to be updated to accept the new API response.

[jdyck-fw]

Sev may have an easy answer on this, and 1 point is to explore if it is so

[severinbeauvais]

In my opinion, the cost of doing this "ideally" is too high for this "simple" fix, so I implemented a special-case solution that capitalizes "Agm" -> "AGM".

Special cases are not ideal but in this case it's simple, extensible, understandable and safe, so I think it's OK.

If we get a lot of special cases then we'll want to look at a better solution, but we're not there yet.

[severinbeauvais]

Test Notes

Look at the title of the output letter for an AGM Location Change (or AGM Extension).

[yuisotozaki]

Ready for QA.