Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCRS Shared Components: port back the Vue3 date picker components #18526

Closed
3 tasks done
severinbeauvais opened this issue Nov 9, 2023 · 1 comment
Closed
3 tasks done
Assignees
Labels
ENTITY Business Team techdebt

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Nov 9, 2023

Other teams have already converted some of the shared components into Vue3 (but are using them locally). Attached are 3 versions of the date picker.

This ticket is to:

  • update/"port back" (or create new components) in the bcrs-shared-components repo, feature-vue3 branch
  • update the stories so the components work correctly in Storybook
  • update libraries to make unit tests work

RangeDatePicker.vue.txt

InputFieldDatePicker.vue.txt

BaseDatePicker.vue.txt

Also, look at using toNative(NameRequestMixin) for mixins.
Ref: https://github.com/facing-dev/vue-facing-decorator/blob/master/src/mixins.ts
Ref: https://blog.logrocket.com/how-to-use-vue-3-typescript/#using-typescript-mixins-vue

@severinbeauvais severinbeauvais changed the title BCRS Shared Components: try to port back some Vue3 components BCRS Shared Components: port back the Vue3 date picker components Nov 10, 2023
@ketaki-deodhar ketaki-deodhar self-assigned this Nov 16, 2023
@severinbeauvais
Copy link
Collaborator Author

@ketaki-deodhar Cameron says he has a Vue3 version of the Fee Summary component. Do you have time in this ticket to import that one, too, or should we create a new ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENTITY Business Team techdebt
Projects
None yet
Development

No branches or pull requests

3 participants