Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namerequest UI: implement Amalgamate Now buttons #18532

Closed
5 tasks done
severinbeauvais opened this issue Nov 10, 2023 · 6 comments
Closed
5 tasks done

Namerequest UI: implement Amalgamate Now buttons #18532

severinbeauvais opened this issue Nov 10, 2023 · 6 comments
Assignees

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Nov 10, 2023

  • add button for numbered amalgamation (search page)
  • add button for approved amalgamation NR (existing NR page)
  • create draft amalgamation filing - for regular amalgamation
  • redirect to Filings UI (aka entity dashboard - same as draft business/IA)
  • use FF if not already implemented that way - one on redirect to COLIN and potentially one on supported entities (which may fit into one FF)

Since the schema ticket is incomplete, look at expected data object here:
https://github.com/bcgov/business-create-ui/pull/583/files#diff-1e39c22aa8040eca1facfbe09d95e68148098507a0387ddd39aa304d9dfbab87

But you only need to create the draft with the minimum data -- same as IA.

@severinbeauvais severinbeauvais added the ENTITY Business Team label Nov 10, 2023
@severinbeauvais
Copy link
Collaborator Author

See #18461 for any additional / detailed requirements.

@jdyck-fw
Copy link
Collaborator

Look through existing code for similar buttons.

@severinbeauvais
Copy link
Collaborator Author

The FF to control which entity types can be amalgamated in the modernized app (instead of going to COLIN) already exists. It is currently empty (meaning all entity types show the "go to COLIN" button). Let me know when you are ready to test this FF and I will change it to "BC CC CR UL" in Dev for you.

Private Zenhub Image

@severinbeauvais
Copy link
Collaborator Author

To explain further, in the amalgamation flow, the following entity types can be selected as the (amalgama)"ted" business:

Private Zenhub Image

Of these, only Limited Company / Unlimited Liability Company / Benefit Company / Community Contribution Company will lead to the creation of a draft amalgamation filing and redirect to Filings UI. The others will:

  • for a named business, lead to the creation of a NR that can only be used in COLIN (same as today)
  • for a numbered business, show a Go To COLIN button (same as today), per the following example:

Private Zenhub Image

@jamespaologarcia
Copy link

jamespaologarcia commented Nov 29, 2023

Testing done:

[✅] entities supported by FF (create draft)
[✅] entities not supported by FF (go to COLIN)
[✅] while not logged in
[✅] while already logged in
[✅] numbered amalgamations (button on search page)
[✅] named amalgamations (button on existing request display page)

@jdyck-fw
Copy link
Collaborator

jdyck-fw commented Dec 4, 2023

@ozamani9gh - ready for someone on your team to review this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants