-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API - Amend Transport Permit API Updates and Outputs #18566
Comments
@LizGovier this ticket will track replacing CHANGE_LOCATION with AMEND_LOCATION as well the API implementation of AMEND_LOCATION. The fee code to use should be included in the ticket description, as well as the legacy document type that AMEND_LOCATION will map to. I think it is PUBA. |
Thank you to whoever updated this! @mstanton1 Will we be adding a $15 fee to this? |
@LizGovier I believe that will be the case but a decision note has been sent to Sinead to review the fees and confirm the path forward. I'll update this ticket when I have her response. Note: I've also added the legacy document type to map to. I imagine this could have mapped to PUBA or REGC but would suspect there are more cases where it maps to PUBA. Do you happen to know? Or I could check with whoever gathered the requirements:) |
@mstanton1 In BCOL, Amending a Transport Permit is filed as a REGC. Staff amend a permit with a PUBA. @doug-lovett I think that's what you mentioned a while ago. |
@LizGovier thank you. I think this should be raised at Requirements. We won't have a way to map the new filing type back to multiple filings types so should probably touch base with staff on what they'd like to see. In theory the impact should be limited because we don't have a ledger of transactions in BCOL that clients could view, and this mapping will only be for Transport Permit amendments done in the new system that are then viewed in legacy. I'll add this to the agenda. |
Given the description, the new code will be AMEND_PERMIT, not AMEND_LOCATION. |
Thank you @doug-lovett, I've updated the description of this ticket to reflect that. |
GET /mhr/api/v1/registrations/{mhrNumber}?current=true now includes new permit properties if available: The API amend transport permit request is identical to the transport permit request but with a new amendment boolean property: POST /mhr/api/v1/permits/107374 |
@LizGovier when you are back, outputs to review: |
Hey @doug-lovett , everything looks good as per the design, but just the 'Amended' badge for the New Registered Location in the outputs isn't displayed, not sure if we are leaving this for Liz to take a look before QA? Thanks!! ACTIVE: |
Thanks @chdivyareddy I missed the badge. The report template update will be in the next API build. I updated the examples in my original comment above after adding the AMENDED badge. |
@chdivyareddy and the report version with the AMENDED badge is now in DEV. |
Thanks for the update @doug-lovett !! |
Verified in DEV! MHR 107938 |
Hey @doug-lovett
|
Thanks @LizGovier below is an example report after making your latest changes. |
Beautiful! Thanks @doug-lovett |
@chdivyareddy the report update is now in TEST and SANDBOX. |
@doug-lovett Thank you!! Verified in TEST! |
When a Transport Permit is submitted but an error is made in the information provided, Amend Transport Permit is used to update the Transport Permit details. This can be performed by staff, or a qualified supplier.
Legacy Document Type to map to: REGC
Fee: MHROT - $15.00
Developer Notes:
If a transport permit exists on the home, update the current view of the home to include:
Business Rules:
Database Notes:
The text was updated successfully, but these errors were encountered: