Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UI - add TING check for draft tasks #19390

Closed
5 tasks done
severinbeauvais opened this issue Jan 19, 2024 · 4 comments
Closed
5 tasks done

Create UI - add TING check for draft tasks #19390

severinbeauvais opened this issue Jan 19, 2024 · 4 comments
Assignees
Labels

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Jan 19, 2024

  • fetch TING business' tasks
  • look for a draft task (DRAFT and PENDING)
  • fail validation if there is a draft task
  • display "Attention Required" with tooltip
  • add unit tests
@severinbeauvais severinbeauvais added the ENTITY Business Team label Jan 19, 2024
@severinbeauvais severinbeauvais changed the title Create UI - add check for draft tasks Create UI - add ting check for draft tasks Jan 19, 2024
@severinbeauvais severinbeauvais changed the title Create UI - add ting check for draft tasks Create UI - add TING check for draft tasks Jan 19, 2024
@severinbeauvais severinbeauvais self-assigned this Jan 19, 2024
@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Jan 19, 2024

@yuisotozaki How about this for a tooltip here?

"This business has a draft filing. It cannot be part of an amalgamation."

"Draft" also means a filing in the Todo List for which the payment is incomplete. But the user can retry the payment or cancel the payment and be left with an actual draft (which they can also delete).

@yuisotozaki
Copy link

I think that makes sense. I think it's straight forward enough. For that scenario where the payment is pending, when the user visits the entity dashboard of that business, they'll see that there's a draft filing that hasn't gone through.

@severinbeauvais
Copy link
Collaborator Author

@yuisotozaki Thanks!

@yuisotozaki
Copy link

Ready for QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants