Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth -Search Name Request - Cancelled Name Request should not be selected #19703

Open
eve-git opened this issue Feb 6, 2024 · 8 comments
Open
Assignees
Labels
bug Something isn't working Names Team Name Request Name Examination Team NRO NRO Replacement

Comments

@eve-git
Copy link
Collaborator

eve-git commented Feb 6, 2024

Steps to reproduce the bug:

  1. login as staff in PROD
  2. go to MBR (My Staff Business Registry)
  3. search for a cancelled NR (for example: NR 4000103)
    The NR is able to be selected. However an error showed up after;

we have: image.png

what expected:
image.png

@eve-git eve-git added the Names Team Name Request Name Examination Team label Feb 6, 2024
@eve-git eve-git added the Pay Work for Pay Team label Feb 7, 2024
@PCC199 PCC199 added the bug Something isn't working label Feb 8, 2024
@seeker25
Copy link
Collaborator

image

NR endpoint needs to filter out CANCELLED

@JohnamLane JohnamLane removed Pay Work for Pay Team sbc-connect labels Sep 11, 2024
@ozamani9gh
Copy link
Collaborator

@davemck513 @sal-hamood I was wondering how urgent this work is.

Cancelled NRs are appearing in Business Search.

from Thor (on sbc-connect)
image.png

please let me know if you want to discuss

@ozamani9gh ozamani9gh self-assigned this Sep 11, 2024
@ozamani9gh
Copy link
Collaborator

i may be wrong, but i believe its in requests.py endpoint search.

@stevenc987
Copy link
Collaborator

stevenc987 commented Sep 24, 2024

@ozamani9gh @Mihai-QuickSilverDev

Do you think if you need to talk to Business guys before we fix something?

image.png

@Mihai-QuickSilverDev
Copy link
Collaborator

Mihai-QuickSilverDev commented Sep 25, 2024

  • @ozamani9gh I was part of the decision already made by the Businesses to not add cancelled NR's to the MBR.
  • Both Staff and customers have other means at their disposal to retrieve and look at such NR's.
  • Eve was correctly pointing above to the correct manifestation, and how it should be resolved.
  • This would be a Priority 2 - imho.
  • Including Janis and Olga here, in case the original decision needs to be reviewed. @janisrogers @OlgaPotiagalova

@stevenc987 stevenc987 assigned stevenc987 and unassigned ozamani9gh Sep 25, 2024
@stevenc987
Copy link
Collaborator

stevenc987 commented Sep 25, 2024

Before updated:
On Devl:
image.png

on TEST:
image.png

@stevenc987
Copy link
Collaborator

Codes has been merged to both main and release-skip-nro-decom branches. It is on Devl only

@Mihai-QuickSilverDev
Copy link
Collaborator

Mihai-QuickSilverDev commented Oct 2, 2024

  • Tested successfully.

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Names Team Name Request Name Examination Team NRO NRO Replacement
Projects
None yet
Development

No branches or pull requests

7 participants