Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHR - Cancelled Transport Permit Unit notes #20535

Closed
2 tasks done
chdivyareddy opened this issue Mar 28, 2024 · 8 comments
Closed
2 tasks done

MHR - Cancelled Transport Permit Unit notes #20535

chdivyareddy opened this issue Mar 28, 2024 · 8 comments
Assignees
Labels
Assets bug Something isn't working

Comments

@chdivyareddy
Copy link
Collaborator

chdivyareddy commented Mar 28, 2024

  • When the staff correct the status from Exempt to Active on a home that has active residential exemption, then the previous active residential exemptions gets cancelled as expected, but displays the submitting party details in the unit notes panel (only for few registrations).
    MHR 107983 in DEV:

image.png

Design:
image.png

  • When there is a transport permit amendment on a home, then the unit notes display as undefined. (These undefined notes are cancelled Transport Permits)

image.png

image.png

@chdivyareddy chdivyareddy added Assets bug Something isn't working labels Mar 28, 2024
@doug-lovett
Copy link
Collaborator

doug-lovett commented Apr 2, 2024

For MHR 107983, the cancelled residential exemption includes the person giving notice for the residential exemption, not the submitting party. I believe including the person giving notice is correct.

The missing 108300 unit note description (undefined) may be due to the document type "AMEND_PERMIT". Here are the API unit notes for this registration:
"notes": [
{
"createDateTime": "2024-03-25T17:09:22+00:00",
"documentDescription": "TRANSPORT PERMIT - AMENDED",
"documentId": "18000177",
"documentRegistrationNumber": "00550315",
"documentType": "AMEND_PERMIT",
"expiryDateTime": "2024-04-25T06:59:59+00:00",
"remarks": "",
"status": "ACTIVE"
},
{
"createDateTime": "2024-03-25T17:03:15+00:00",
"documentDescription": "TRANSPORT PERMIT - AMENDED",
"documentId": "18000052",
"documentRegistrationNumber": "00550313",
"documentType": "AMEND_PERMIT",
"expiryDateTime": "2024-04-25T06:59:59+00:00",
"remarks": "",
"status": "CANCELLED"
},
{
"createDateTime": "2024-03-25T16:59:05+00:00",
"documentDescription": "TRANSPORT PERMIT - AMENDED",
"documentId": "18000099",
"documentRegistrationNumber": "00550312",
"documentType": "AMEND_PERMIT",
"expiryDateTime": "2024-04-25T06:59:59+00:00",
"remarks": "",
"status": "CANCELLED"
},
{
"createDateTime": "2024-03-25T16:55:21+00:00",
"documentDescription": "TRANSPORT PERMIT",
"documentId": "18000077",
"documentRegistrationNumber": "00550310",
"documentType": "REG_103",
"expiryDateTime": "2024-04-25T06:59:59+00:00",
"remarks": "",
"status": "CANCELLED"
}
],

@chdivyareddy
Copy link
Collaborator Author

Good Morning @doug-lovett , for the residential exemption, we don't have the person giving notice component in the UI. It's just the Document ID and remarks section where user has to fill and in the review and confirm we have the submitting party. Looks like the submitting party details are displayed for the legacy registrations for the residential exemption filings.

MHR 107768 in DEV

image.png

image.png

New application registration: 108297

image.png

@doug-lovett
Copy link
Collaborator

@chdivyareddy the modernized residential exemption registrations may not have a person giving notice, but the legacy unit note record does have contact information. If this information is to be suppressed in the UI then an API change is required: it is not a bug.

@chdivyareddy
Copy link
Collaborator Author

@doug-lovett , that makes sense, thanks for the information:)

@cameron-eyds cameron-eyds changed the title MHR - Unit notes component MHR - Cancelled Transport Permit Unit notes Apr 4, 2024
@cameron-eyds cameron-eyds self-assigned this Apr 4, 2024
@LizGovier
Copy link
Collaborator

LizGovier commented Apr 5, 2024

Hey @doug-lovett, to be consistent with the new Res-Exemption UI for Unit Notes, could you remove the person giving notice information thats coming from legacy. Would you like a separate API ticket for this?

@doug-lovett
Copy link
Collaborator

Hey @LizGovier yes please. It may be other document types as well where we want to ignore the note name and address.

@LizGovier
Copy link
Collaborator

@doug-lovett I created ticket #20615 which I'll tag you in.

@chdivyareddy
Copy link
Collaborator Author

Verified in DEV for the transport permit amendment unit notes.

image.png

@PCC199 PCC199 closed this as completed Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assets bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants