Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Namex Transaction History messages #6423

Closed
3 tasks done
sienna-oldaccountdontuse opened this issue Feb 8, 2021 · 9 comments
Closed
3 tasks done

Improve Namex Transaction History messages #6423

sienna-oldaccountdontuse opened this issue Feb 8, 2021 · 9 comments
Assignees
Labels
ENTITY Business Team Name Request NameX NameX and related services proxied via namex

Comments

@sienna-oldaccountdontuse
Copy link
Contributor

sienna-oldaccountdontuse commented Feb 8, 2021

Description

The transaction history in NameX isn't very useful, and has technical jargon. We should make it more like what is currently displayed in SOFI NRO, specifically explaining what is changing and when. These messages will be more useful to staff. We need this before NRO is decommission.

For analysis

  • Find different name requests in NameX test
  • Go to SOFI, go to NRO tab, view the name request in NRO
  • Document the transaction history

Examples of transaction histories in NRO and NameX

Summary of analysis:
NameX just lists API interactions? But does not compare the old data to the new to highlight what has changed. It is pretty much useless to a Names Examiner.

@forgeuxGH5 @tlebedovich , how should we display the transaction information, based on the info they need? Name request displays everything and highlights what is new. one idea might be to just display what has changed? But maybe staff like seeing a recent snapshot of the name request, in addition to the highlighted changed?

@kialj876 - SEE DESIGN TICKET ATTACHED BELOW AS A DEPENDENCY

@sienna-oldaccountdontuse sienna-oldaccountdontuse added ENTITY Business Team Name Request NameX NameX and related services proxied via namex labels Feb 8, 2021
@Kaineatthelab
Copy link
Collaborator

it is interesting the both show changes to the state but the info to examiners seems like namex isn't showing what they want, should we just do what nro does?

@forgeuxGH5
Copy link
Collaborator

I pulled the original design for Transaction History - we might want to update the top section to parallel our designs for NR summary but the idea is there:
https://app.zenhub.com/files/157936592/e371c6e4-de2f-451c-a946-408111ab19e1/download

@sienna-oldaccountdontuse
Copy link
Contributor Author

From what I saw in NRO, Scott's design above looks like examiners would have what they need. Maybe we should run it by them and see if it would meet their requirements?

@Kaineatthelab
Copy link
Collaborator

@Sienna-Blumstengel yes would need them to give some feedback for sure

@sienna-oldaccountdontuse
Copy link
Contributor Author

sienna-oldaccountdontuse commented Mar 31, 2021

Meeting notes from Debbie's team standup, showing the transaction history designs:
@forgeuxGH5 FYI

  • Busy, quite a lot in one view. Can see everything without minimizing.

  • Do you want the ability to minimize? Have a close all, or open all button?

  • Maybe if the lines were to go in succession. Like draft, conditionally approved, consent provided, approved. As opposed to the way it's set up now. I want it to go oldest first. Right now draft is at the bottom.. i prefer oldest at the top.

  • I am the opposite, I want to see the newest at the top. Yeah me too. (evenly split on order)

  • Right now, I never have to click to open things, everything I need is at a glance. This doesn't have that same effect, i need to search for info.

  • Sounds like you want everything expanded. I am going to say we don't need the ability to collapse them then?

  • Let's have the basic NRO info at the very top, then we will see what we need at a glance. We need a current snapshot of the NR. I rarely use the actual history of where the NR has changed.

  • Yeah, we were not really using all of that old NRO page with the individual transactions. We needed a snapshot of all the info about the NR.

  • I like the top part there, but I need if it's approved (what the results are). Thats the most important thing that is missing from there.

  • Every transaction is a separate line. Let's combine them.

  • Also, i don't know where to find out what the original name was, from here. I would like to see that upfront, not hidden in a dropdown.

  • Can we highlight what changed? So it's really easy to see? Like NRO?

  • This example is a bit confusing, some data in the example wouldn't happen in real life.
    .

  • This info at the top, the summary stuff, would normally be in the last "snapshot" in NRO.
    .

  • I would like bigger text. I would like that sidebar info on the right to be at the top with each snapshot so all the data is together.
    .

  • Main issue: NameX is making us click through to much to get to the same info in NRO that was easy to find. Why re-design this when it was working fine before? The NRO transaction history was perfect for what we needed. Can we just have a newer shiner version of the NRO transaction history?

@tlebedovich
Copy link

testing notes -

creating a new NR via namerequest and changing stuff / examining it in namex-dev is the best way to test it




older ones still need to be looked at but they will not have all the events / info required for all the fields always


@tlebedovich
Copy link

tlebedovich commented May 28, 2021

hi @kialj876 - Looks awesome, here were the few small items I noticed:

  • If not Priority, the top header's NR Number should be #494949 (not red) and you do not need to display "Regular" in the top header, please just hide that word and vertical line when its not a Priority request.

"Regular" = NR NUMBER l Company Type

Screen Shot 2021-05-28 at 9.00.22 AM.png

  • Look into the issue where the status is getting reset when editing and blue check isn't appearing in the header when conditionally approved, but showing in the history etc (as per our call NR 2796343)

  • Set the order of the names in the history to always be 1, 2, 3

  • If there is no Transaction History, show blank white page under the header bar with a “No transaction history data available.” message.

  • Under consent - do we need to show a period after "Not Required"? (its really only needed for "Required. Received."

  • Anyway to fix/remove the gap at the bottom of the page?

Screen Shot 2021-05-28 at 9.00.00 AM.png

@tlebedovich
Copy link

@kialj876 -

I will move this along to QA, I know you are looking into a 500 error for NR 1889956.

And if its a quick and easy update to change the "No Data" message to “No transaction history data available.” for NRs that don't have transaction history available to show.

Thanks!

@kialj876
Copy link
Collaborator

kialj876 commented Jun 1, 2021

added fixes for both of these (the NR 1889956 had bad data that I don't think would happen in PROD, but I'm not 100% certain so i've added a fix that will handle that now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENTITY Business Team Name Request NameX NameX and related services proxied via namex
Projects
None yet
Development

No branches or pull requests

6 participants