Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All UI: stamp keycloak & configuration json files with unique name/attribute #7120

Closed
thorwolpert opened this issue Apr 12, 2021 · 3 comments
Assignees
Labels

Comments

@thorwolpert
Copy link
Collaborator

What is the problem?

  • caching of these non-unique files makes the applications un-useable when changes are rolled through

What is the impact?

  • customers have to hard-refresh, or go further and break sw caches in order to obtain the new configuration.

Proposed solution

  • This is already solved by webpack, esbuild, etc where a unique hash is added to the file name. A similar approach should be taken for these 2 configuration files.
  • the file could be pre-pended by an arbitrary hash, commit hash, dates, or something else that the deployments and builder system can mutually leverage.
@Kaineatthelab
Copy link
Collaborator

For grooming? Seems pretty high priority

@thorwolpert
Copy link
Collaborator Author

I was thinking we would fix it in PPR first, in conjunction with the common header, and then roll the suggested change to the rest.

@lmcclung
Copy link
Contributor

Thor's approach sounds good. Let me know once you've done PPR and then we can do a ticket for the Entities stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants