From de154651f82daf74d25f3258e0dbaa794034de9c Mon Sep 17 00:00:00 2001 From: Severin Beauvais Date: Tue, 12 Sep 2023 09:20:51 -0700 Subject: [PATCH] - app version = 5.0.43 - misc cleanup - renamed EntityType -> EntityTypes - renamed CompanyType -> CompanyTypes - cleaned up PickEntityOrConversion.vue - added category table for xpro (amalgamation only) - moved many NrApprovedGrayBox props into component - renamed isSupportedEntity -> isSupportedIncorporationRegistration - changed isXProCompany -> isXproEntityType - added Alter Now button to NrApprovedGrayBox - added template blocks for amalgamation to Search - renamed companyRadioBtnApplicable -> showCompanyTypeRadioButtons - added amalgamation form URL to Search - added AML blurbs to Entity Types Data - added "Extraprovincial" to all xpro business labels - added XCR and XCP to AML xpro mapping - renamed isSupportedEntity -> isSupportedEntityType - added isSupportedAmalgamation() - added some store getters - deleted debugging strings - removed debugging code --- package-lock.json | 4 +- package.json | 2 +- src/App.vue | 2 +- src/components/common/app-title-cols.vue | 20 +- src/components/common/names-capture.vue | 22 +- .../dialogs/pick-entity-or-conversion.vue | 126 ++++++---- .../check-status-gray-box.vue | 5 +- .../existing-request-display.vue | 70 +----- .../existing-request/name-request-details.vue | 4 +- .../existing-request/nr-approved-gray-box.vue | 128 ++++++++-- .../new-request/business-lookup.vue | 4 +- src/components/new-request/grey-box.vue | 14 +- .../new-request/name-check/name-check.vue | 30 +-- src/components/new-request/name-input.vue | 2 + src/components/new-request/search.vue | 138 ++++++----- .../entity-cannot-be-auto-analyzed.vue | 6 +- .../{company-type.ts => company-types.ts} | 2 +- src/enums/{entity-type.ts => entity-types.ts} | 2 +- src/enums/index.ts | 4 +- src/interfaces/business.ts | 4 +- src/interfaces/mapping.ts | 6 +- src/interfaces/models.ts | 10 +- src/interfaces/new-request-interface.ts | 8 +- src/list-data/conversion-types.ts | 26 +- src/list-data/entity-type-data.ts | 97 ++++---- src/list-data/request-action-mapping.ts | 141 +++++------ src/list-data/request-actions.ts | 2 +- src/mixins/common-mixin.ts | 123 +++++----- src/mixins/nr-affiliation-mixin.ts | 2 +- src/plugins/index.ts | 3 +- src/store/actions.ts | 14 +- src/store/getters.ts | 229 +++++++++--------- src/store/mutations.ts | 6 +- src/store/state.ts | 16 +- src/views/landing.vue | 12 - 35 files changed, 671 insertions(+), 613 deletions(-) rename src/enums/{company-type.ts => company-types.ts} (73%) rename src/enums/{entity-type.ts => entity-types.ts} (97%) diff --git a/package-lock.json b/package-lock.json index c734378e3..89ee06803 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "name-request", - "version": "5.0.42", + "version": "5.0.43", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "name-request", - "version": "5.0.42", + "version": "5.0.43", "dependencies": { "@babel/compat-data": "^7.12.13", "@bcrs-shared-components/breadcrumb": "2.1.24", diff --git a/package.json b/package.json index d32de288a..af63a7ea0 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "name-request", - "version": "5.0.42", + "version": "5.0.43", "private": true, "appName": "Name Request UI", "sbcName": "SBC Common Components", diff --git a/src/App.vue b/src/App.vue index 31cd6114a..50311b7be 100644 --- a/src/App.vue +++ b/src/App.vue @@ -253,7 +253,7 @@ export default class App extends Mixins( sessionStorage.removeItem('NR_DATA') } - // if there is stored legal type for an IA then incorporate it now + // if there is stored legal type for an IA then incorporate/register it now const legaltype = sessionStorage.getItem('LEGAL_TYPE') if (legaltype) { try { diff --git a/src/components/common/app-title-cols.vue b/src/components/common/app-title-cols.vue index 20be0b9e3..b91fd63dd 100644 --- a/src/components/common/app-title-cols.vue +++ b/src/components/common/app-title-cols.vue @@ -1,15 +1,13 @@ diff --git a/src/components/new-request/business-lookup.vue b/src/components/new-request/business-lookup.vue index 4496fddde..7084253d0 100644 --- a/src/components/new-request/business-lookup.vue +++ b/src/components/new-request/business-lookup.vue @@ -50,7 +50,7 @@ import { Component, Emit, Prop, Watch } from 'vue-property-decorator' import { debounce } from 'lodash' import { BusinessLookupResultIF, BusinessSearchIF } from '@/interfaces' import BusinessLookupServices from '@/services/business-lookup-services' -import { EntityStates, EntityType } from '@/enums' +import { EntityStates, EntityTypes } from '@/enums' enum States { INITIAL = 'initial', @@ -131,7 +131,7 @@ export default class BusinessLookup extends Vue { return { identifier: input.identifier, legalName: input.name, - legalType: (input.legalType as unknown as EntityType), + legalType: (input.legalType as unknown as EntityTypes), state: input.status } } diff --git a/src/components/new-request/grey-box.vue b/src/components/new-request/grey-box.vue index 007c2ef88..962c524e7 100644 --- a/src/components/new-request/grey-box.vue +++ b/src/components/new-request/grey-box.vue @@ -142,7 +142,7 @@ import ReserveSubmit from '@/components/new-request/submit-request/reserve-submi import { AnalysisJSONI, OptionI } from '@/interfaces' import { replaceWord } from '@/plugins' import { ActionBindingIF } from '@/interfaces/store-interfaces' -import { EntityType } from '@/enums' +import { EntityTypes } from '@/enums' import { AllDesignationsList, Designations } from '@/list-data' @Component({ @@ -173,7 +173,7 @@ export default class GreyBox extends Vue { // Global getters @Getter getAnalysisJSON!: AnalysisJSONI @Getter getDesignationIssueTypes!: string[] - @Getter getEntityTypeCd!: EntityType + @Getter getEntityTypeCd!: EntityTypes @Getter getName!: string @Getter getRequestExaminationOrProvideConsent!: boolean @@ -219,8 +219,12 @@ export default class GreyBox extends Vue { } get isAssumedNameEntityType () { - return this.entity_type_cd !== EntityType.XLP && this.entity_type_cd !== EntityType.XLL && - this.entity_type_cd !== EntityType.XCP && this.entity_type_cd !== EntityType.XSO + return ( + this.entity_type_cd !== EntityTypes.XLP && + this.entity_type_cd !== EntityTypes.XLL && + this.entity_type_cd !== EntityTypes.XCP && + this.entity_type_cd !== EntityTypes.XSO + ) } get allDesignationsStripped () { @@ -274,7 +278,7 @@ export default class GreyBox extends Vue { return null } - get entity_type_cd (): EntityType { + get entity_type_cd (): EntityTypes { return this.getEntityTypeCd } diff --git a/src/components/new-request/name-check/name-check.vue b/src/components/new-request/name-check/name-check.vue index af63861f2..e9ad2ac3a 100644 --- a/src/components/new-request/name-check/name-check.vue +++ b/src/components/new-request/name-check/name-check.vue @@ -203,7 +203,7 @@ import NameCheckConflicts from '@/components/new-request/name-check/name-check-c import NameCheckTabContent from '@/components/new-request/name-check/name-check-tab-content.vue' import NameInput from '@/components/new-request/name-input.vue' import QuickSearchNames from '@/components/new-request/name-check/quick-search-names.vue' -import { EntityType, NameCheckErrorType } from '@/enums' +import { EntityTypes, NameCheckErrorType } from '@/enums' import { ConditionalInstructionI, DialogOptionsI, NameCheckErrorI, NameCheckItemIF } from '@/interfaces' import { ActionBindingIF } from '@/interfaces/store-interfaces' import { baseItemsConflicts, baseItemsStructure } from './resources' @@ -230,7 +230,7 @@ export default class NameCheck extends Vue { @Getter getDesignationsMismatched!: Array @Getter getDesignationsMisplaced!: Array @Getter getEntityTextFromValue!: string - @Getter getEntityTypeCd!: EntityType + @Getter getEntityTypeCd!: EntityTypes @Getter getErrors!: string[] @Getter getFullName!: string @Getter getLocationText!: string @@ -351,8 +351,8 @@ export default class NameCheck extends Vue { } get designationOptions (): Array { let output: string[] = Designations[this.getEntityTypeCd]?.words - if (this.getEntityTypeCd === EntityType.CC) { - output = Designations[EntityType.CR].words + if (this.getEntityTypeCd === EntityTypes.CC) { + output = Designations[EntityTypes.CR].words } return output } @@ -537,19 +537,19 @@ export default class NameCheck extends Vue { if (this.hasDesignationsCheckUse) { let newItem = baseItemsStructure.designationsCheckUse const propEntities = [ - EntityType.FR, - EntityType.DBA, - EntityType.GP, - EntityType.LP, - EntityType.LL, - EntityType.XLP, - EntityType.XLL + EntityTypes.DBA, + EntityTypes.FR, + EntityTypes.GP, + EntityTypes.LL, + EntityTypes.LP, + EntityTypes.XLL, + EntityTypes.XLP ] if (propEntities.includes(this.getEntityTypeCd)) { newItem = baseItemsStructure.designationsCheckUseProp - } else if ([EntityType.CP, EntityType.XCP].includes(this.getEntityTypeCd)) { + } else if ([EntityTypes.CP, EntityTypes.XCP].includes(this.getEntityTypeCd)) { newItem = baseItemsStructure.designationsCheckUseCP - } else if (this.getEntityTypeCd === EntityType.CC) { + } else if (this.getEntityTypeCd === EntityTypes.CC) { newItem = baseItemsStructure.designationsCheckUseCCC } newItem.words = this.designationsCheckUse @@ -572,9 +572,9 @@ export default class NameCheck extends Vue { } if (this.isMissingDesignation) { let newItem = baseItemsStructure.designationsMissing - if ([EntityType.CP, EntityType.XCP].includes(this.getEntityTypeCd)) { + if ([EntityTypes.CP, EntityTypes.XCP].includes(this.getEntityTypeCd)) { newItem = baseItemsStructure.designationsMissingCP - } else if (this.getEntityTypeCd === EntityType.CC) { + } else if (this.getEntityTypeCd === EntityTypes.CC) { newItem = baseItemsStructure.designationsMissingCCC } items.push(newItem) diff --git a/src/components/new-request/name-input.vue b/src/components/new-request/name-input.vue index d818890b2..98176b538 100644 --- a/src/components/new-request/name-input.vue +++ b/src/components/new-request/name-input.vue @@ -31,8 +31,10 @@ import { MRAS_MAX_LENGTH } from '@/components/new-request/constants' export default class NameInput extends Vue { /** Whether to perform MRAS search. */ @Prop({ default: false }) readonly isMrasSearch!: boolean + /** Whether this component is read-only (eg, on name check page). */ @Prop({ default: false }) readonly isReadOnly!: boolean + /** Hint to show (eg, on name check page). */ @Prop({ default: null }) readonly hint!: string diff --git a/src/components/new-request/search.vue b/src/components/new-request/search.vue index 711fc9155..976b91fae 100644 --- a/src/components/new-request/search.vue +++ b/src/components/new-request/search.vue @@ -133,10 +133,10 @@ - +