Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

67.2 Email Templates New Iteration #1811

Closed
funtigr opened this issue Jan 17, 2024 · 4 comments
Closed

67.2 Email Templates New Iteration #1811

funtigr opened this issue Jan 17, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@funtigr
Copy link
Collaborator

funtigr commented Jan 17, 2024

Follow up of #1680
Fixes left to do in Email Templates:

  1. Keep Admin Request for non-Create requests template (PrivateCloudAdminRequest) and add Current and Requested data like in Edit Request
  2. (old 4) In PrivateCloudAdminCreateRequest and PrivateCloudAdminRequest templates delete the header "Namespace Details" but leave the cluster data
  3. (old 8) Delete the text that signifies Edit or Create request to make text universal in Completed Request emails (PrivateCloudRequestProvisioned and PrivateCloudRequestApproved)
  4. (old 9) Same as point 8 (Universal wording) and delete “admin” in the text for Public Cloud Completed Request templates (PublicCloudRequestProvisioned and PublicCloudRequestApproved)
  5. (old 15) Add comment from Admin (mandatory to Submit Approval) to Rejection and Approved templates for both Public and Private cloud (will require creation of the new component)
  6. If user creates an Edit Request they receive an email with the header that it's Approved while it's not:

image.png

@Iryna-Kaplun Iryna-Kaplun added the bug Something isn't working label Jan 18, 2024
@Iryna-Kaplun Iryna-Kaplun changed the title Email Templates New Iteration 67.2 Email Templates New Iteration Jan 18, 2024
@Amritpal-Nijjar
Copy link
Contributor

Amritpal-Nijjar commented Jan 22, 2024

Emails w/ comments

  • PrivateCloudEditRequest -User- -working-
  • PrivateCloudRequestApproval -Admin -not working-
  • PrivateCloudRequestRejection -Admin- -not working-
  • PubliCloudEditRequest -User- -not working-
  • PublicCloudRequestApproval -Admin- -not working-
  • PublicCloudRequestRejection -Admin- -not working-

@funtigr
Copy link
Collaborator Author

funtigr commented Jan 25, 2024

@Amritpal-Nijjar @okanji
Added a new point in the task:
If user creates an Edit Request they receive an email with the header that it's Approved while it's not:
image.png

@funtigr
Copy link
Collaborator Author

funtigr commented Jan 26, 2024

Don't see the changes yet:
image.png
image.png

@funtigr
Copy link
Collaborator Author

funtigr commented Feb 8, 2024

Everything is tested out and works good except these:
3. Approval Request is mutual for Create and Edit Request but it has wording about the new project set and about level of access (which is usually only mentioned when the new product is created).
image.png
4. The Public Cloud has mention of the Admin access which is not true in Public Cloud. Also it is information that is only suitable for creation approval and not for edit approval.
image.png

@funtigr funtigr closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants