Skip to content
This repository has been archived by the owner on Oct 26, 2023. It is now read-only.

The bot should detect reference style links for status badge usage #144

Open
jleach opened this issue May 10, 2021 · 3 comments
Open

The bot should detect reference style links for status badge usage #144

jleach opened this issue May 10, 2021 · 3 comments
Labels
bug Something isn't working neverstale

Comments

@jleach
Copy link
Member

jleach commented May 10, 2021

Describe the issue

The bot does not correctly detect reference style links used for status badges:

[![Lifecycle][lifecycle-shield]](https://github.com/bcgov/repomountie/blob/master/doc/lifecycle-badges.md)
[lifecycle-shield]: https://img.shields.io/badge/Lifecycle-Stable-97ca00?style=for-the-badge

Additional context

Example repository: bcgov/containerization-and-cloud-economic-model#22

Definition of done

The bot correctly detects reference style links in a projects MD file and deals with them appropriately.

@DerekRoberts
Copy link
Member

@jleach Reference-style links removed after latest false positive. Path of least resistance.

bcgov/containerization-and-cloud-economic-model#26
bcgov/containerization-and-cloud-economic-model#27

@stephhazlitt
Copy link
Member

I am not sure if this is related, however the bot opened a Add project lifecycle badge Issue when there is an existing lifestyle badge in the README bcgov/imit-procurement-data-analysis#8

@DerekRoberts
Copy link
Member

DerekRoberts commented May 13, 2021

@stephhazlitt The bot is likely caught up on formatting. It can't hurt to try this team on Rocket.Chat's #devops-how-to channel.

E.g. https://img.shields.io/badge/Lifecycle-Dormant-%23ff7f2a vs https://img.shields.io/badge/Lifecycle-Dormant

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working neverstale
Projects
None yet
Development

No branches or pull requests

3 participants