Fix schedule concurrency errors #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
commented
Sep 11, 2024
| public async Task<T> HandleConcurrencyAsync<T>(Func<Task<T>> callbackDelegate) | ||
| { | ||
| // Keep trying to update the record and handle concurrency errors. | ||
| while (true) |
There was a problem hiding this comment.
Essentially keep trying until successful. It will only error out if the exception is not a optimistic concurrency error.
| { | ||
| // If it's a concurrency error, keep trying. Otherwise throw the error. | ||
| this.Logger.LogError(ex, "Failed to complete request. Determining if this is a concurrency error."); | ||
| var data = ex.Data["Body"] as string; |
There was a problem hiding this comment.
I couldn't find a safe way to determine if the key exists in the dictionary. Regrettably .net uses a IDictionary object that doesn't have those features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common error is related to updated the schedule event. It will often throw an optimistic concurrency error due to various race conditions. This new code will attempt to resolve that type of issue by fetch the latest, reapplying changes and then saving.
Summary