Fix add to report #2295
Merged
Fix add to report #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
added
bug
Fosol
commented
Sep 26, 2024
| @@ -55,13 +55,14 @@ export const AddToReportMenu: React.FC<IAddToReportMenuProps> = ({ content, onCl | |||
|
|
|||
| if (!report.instances.length) { | |||
| // Fetch the report because the one in memory has no instances. | |||
| currentReport = await getReport(report.id); | |||
| currentReport = await getReport(report.id, true); | |||
There was a problem hiding this comment.
This was causing issues on the first time adding content to a report.
| @@ -72,7 +72,7 @@ spec: | |||
| buildVar="${1/\-/\_}" | |||
| # convert to uppercase | |||
| buildVar="${buildVar^^}" | |||
| BUILD_${buildVar}=true | |||
| BUILD=BUILD_${buildVar}=true | |||
There was a problem hiding this comment.
Fixed bug I introduced. However, the test pipeline still doesn't work for some reason.
| @@ -410,6 +410,7 @@ Auth__Keycloak__Secret={YOU WILL NEED TO GET THIS FROM KEYCLOAK} | |||
| Auth__OIDC__Token=/realms/mmi/protocol/openid-connect/token | |||
|
|
|||
| Service__ApiUrl=http://host.docker.internal:$portApi/api | |||
| Service__DataLocation=Openshift | |||
There was a problem hiding this comment.
Makes it easier for new resources to get the syndication service running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial fix for add content to report. A more complex fix needs to be implemented to sync multiple tabs, but this should resolve a few errors.