Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accurate number parsing #226

Open
9il opened this issue May 10, 2021 · 4 comments
Open

Accurate number parsing #226

9il opened this issue May 10, 2021 · 4 comments
Assignees

Comments

@9il
Copy link

9il commented May 10, 2021

Current implementation has inaccurate number parsing.

How to Read Floating Point Numbers Accurately by William D. Clinger - a classic paper on number parsing.

@beached
Copy link
Owner

beached commented May 11, 2021

This is currently being looked at and has some patching
#182

@beached beached self-assigned this May 31, 2021
@beached beached added this to the v3.0 milestone May 31, 2021
@beached beached linked a pull request May 31, 2021 that will close this issue
@beached
Copy link
Owner

beached commented May 31, 2021

Number parsing has a precise mode now, but performance has not been optimized

@beached beached removed this from the v3.0 milestone Jun 28, 2022
@benstadin
Copy link

What is the performance penalty roughly when setting options::IEEE754Precise? And does setting this option address the issue entirely?

@beached
Copy link
Owner

beached commented Jun 7, 2024

Depends on the system, but the cost of from_chars if it supports FP. I am currently working on implementing https://arxiv.org/abs/2212.06644 which should largely remove most of the cost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants