Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validating emails prior to send email #380

Closed
speeddragon opened this issue May 2, 2018 · 3 comments
Closed

Validating emails prior to send email #380

speeddragon opened this issue May 2, 2018 · 3 comments

Comments

@speeddragon
Copy link
Contributor

Hi, I'm using bamboo and it is working great. I've notice that I didn't validate the email address before sending an email (or on register the email on the database).

Shouldn't bamboo provide some method to validate emails ? And also shouldn't that be used to validate the email before send ?

@denvaar
Copy link

denvaar commented Jun 16, 2018

I think I have the same question as you: #403

@lancejjohnson
Copy link
Contributor

@speeddragon Thanks for the question and recommendation for improvement. Can you describe in more detail what you mean by validating email addresses? Do you mean comparing the provided email address with some regular expression? Or do you mean validating the email address against a remote service?

@speeddragon
Copy link
Contributor Author

Looking back, I didn't add enough information to this issue, so know I don't remember exactly what was the problem. I think it was the email field wasn't checked against a regex for email validation. Either way, looking at #403 looks to be a good improvement and might solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants