Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional dynamic parameter support #389

Closed
scott-taubman opened this issue Mar 2, 2023 · 0 comments · Fixed by #411
Closed

Additional dynamic parameter support #389

scott-taubman opened this issue Mar 2, 2023 · 0 comments · Fixed by #411
Assignees
Labels
bug Something isn't working

Comments

@scott-taubman
Copy link
Contributor

scott-taubman commented Mar 2, 2023

Certain types of dynamic parameters still do not work properly. Any attempt to task them will effectively break the entire UI. One such example is the evaluate command in the dynamic example plugin.

Other types do not break the entire site, but simply do not render anything on the tasking screen. One such example is the say_specific_dictionary_with_key_reference command.

The first goal of this issue is to make it these specific example commands (dynamic/evaluate and dynamic/say_specific_dictionary_with_key_reference) work properly. If at all possible however, we should really make it so that dynamic commands just generically work and are less of a specific code path for each and every variation.

Bonus points if we can make it so that the entire application doesn't break in the event that an error is encountered when handling an unsupported dynamic parameter.

@scott-taubman scott-taubman added the bug Something isn't working label Mar 2, 2023
@west270 west270 linked a pull request May 10, 2023 that will close this issue
@west270 west270 self-assigned this May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants