425 Add dynamic command status indicator #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obr42
requested changes
Jun 30, 2023
There was a problem hiding this comment.
Love the look of the indicator!
say_specific_with_choices_argument(s) both work as expected
say_specific_dictionary_with_key_reference shows the indicator, selecting an instance doesn't return anything but the indicator goes away without providing any options
All the URL related commands have an error the infinite loops
obr42
approved these changes
Jul 12, 2023
west270
force-pushed
the
dynamic-command-status-indicator
branch
from
46116d8 to
780d0a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #425
Added a
Tooltipwith anAlertorCircularProgressto the field label to indicate when a dependent field needs selected, if there was an error loading the choices or the choices are currently being loaded.I found an issue with self referring dynamic commands where setting
registerOptions.setValueAscaused a render loop and had to deleteregisterOptions.setValueAsso self referring dynamic commands would work again.