Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console error: useEffect cleanup #430

Merged
merged 1 commit into from
Jul 12, 2023
Merged

console error: useEffect cleanup #430

merged 1 commit into from
Jul 12, 2023

Conversation

west270
Copy link
Contributor

@west270 west270 commented Jul 7, 2023

Closes #429

Reworked the useEffects for the CommandView page to resolve the console error.

@west270 west270 requested a review from obr42 July 7, 2023 18:58
obr42
obr42 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@obr42 obr42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had difficulty repeating the console error - probably was on a specific command/job that I can't remember which it was. ...Changes look ok, no issues with simple commands

Update: was able to find the error on a different branch and confirmed it is gone on this one

@obr42 obr42 merged commit 06595fa into beer-garden:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obr42 obr42 obr42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

console error: useEffect cleanup
2 participants
@west270 @obr42