Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discogs: "3 vinyl split" release not possible to add #4290

Closed
JOJ0 opened this issue Feb 20, 2022 · 5 comments
Closed

discogs: "3 vinyl split" release not possible to add #4290

JOJ0 opened this issue Feb 20, 2022 · 5 comments
Labels
needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature."

Comments

@JOJ0
Copy link
Member

JOJ0 commented Feb 20, 2022

Sorry for being brief here for now. I will elaborate the problem later. Not sure if it is a discogs tagger only problem. Will investigate.

Not-technically speaking the problem is: Sometimes albums (releases in discogs speak) were put out on several vinyls (catalog numbers MM129A, MM129B, MM129C in this case). They all share the same master release. For example these 2 vinyls were available to buy separately:

Screen Shot 2022-02-20 at 12 01 40

https://www.discogs.com/release/830530-Dave-Clarke-Remixes-Rarities-1992-2005

https://www.discogs.com/release/830537-Dave-Clarke-Remixes-Rarities-1992-2005

(There is a third one MM129C but I don't want to tag it because I don't have the mp3, if that matters...)

Importing the first one works fine but when trying to import the second one, beets always wants to overwrite the previously imported one:

Enter release ID: 830537
Tagging DJ Rush - Dave Clarke Presents Remixes & Rarities Part B-(MM 129B) Vinyl
Searching for album ID: 830537
Requesting MusicBrainz release 830537
Invalid MBID (830537).
discogs: Searching for release 830537
discogs: Searching for master release 93537
Sending event: albuminfo_received
Candidate: Dave Clarke - Remixes & Rarities 1992-2005 (830537)
Computing track assignment...
...done.
Success. Distance: 0.57
Evaluating 1 candidates.
Sending event: before_choose_candidate
Correcting tags from:
    DJ Rush - Dave Clarke Presents Remixes & Rarities Part B-(MM 129B) Vinyl
To:
    Dave Clarke - Remixes & Rarities 1992-2005
URL:
    https://www.discogs.com/release/830537-Dave-Clarke-Remixes-Rarities-1992-2005
(Similarity: 43.0%) (tracks, artist, album, source, country) (Discogs, Vinyl, 2006, Belgium, Music Man Records, MM129B)
 * Freaks on Hubbard (Dave Clarke Remix).Mp3 - Cm - 143             -> Freaks On Hubbard (Dave Clarke Remix) (id, title)
 * B2-Lie to Me (Dave Clarke Full Vocal Version).Mp3 - Gm - 66 (#3) -> Lie To Me (Dave Clarke Remix) (#2) (title, index)
 * B1-La La Land (Dave Clarke Remix).Mp3 - Abm - 136 (#2)           -> La La Land (Dave Clarke Remix) (#3) (id, index, title)
Apply, More candidates, Skip, Use as-is, as Tracks, Group albums,
Enter search, enter Id, aBort, plaY, eDit, edit Candidates? a
Sending event: import_task_choice
found duplicates: [123]
default action for duplicates: a
This album is already in the library!
Old: 3 items, MP3, 221kbps, 15:27, 24.7 MiB
New: 3 items, MP3, 209kbps, 17:49, 26.8 MiB
[S]kip new, Keep all, Remove old, Merge all?

Not sure if it's because the album/release name is the same or it is because of the same master release (https://www.discogs.com/master/93537-Dave-Clarke-Remixes-Rarities-1992-2005)

Setup

  • OS: macOS 10.13
  • Python version: 3.9.x
  • beets version: git latest
  • Turning off plugins made problem go away (yes/no): no

My configuration (output of beet config) is:

FIXME
@sampsyo sampsyo added the needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature." label Feb 21, 2022
@sampsyo
Copy link
Member

sampsyo commented Feb 21, 2022

FWIW, it's because they have the same artist and title—that's how beets' "duplicate detection" works. #4199 may be relevant to you, or you may just choose "Keep all" at this prompt.

@JOJ0
Copy link
Member Author

JOJ0 commented Feb 21, 2022

I'll try keep all... thanks!

@JOJ0
Copy link
Member Author

JOJ0 commented Feb 22, 2022

Yes, sorry for the hassle I thought I tried out all the options on import but obviously I didn't realize that choosing "Keep All" does just what I want:

$ beet ls 'catalognum::MM129.*'
Dave Clarke - Remixes & Rarities 1992-2005 - 01 - Hot In The Heels Of Love (Dave Clarke Remix) (2006/Belgium) [MM129A]  211kbps  m:2016-09-14 08:06:06  a:2016-09-14 08:06:06 relaxed:$mood_relaxed
Dave Clarke - Remixes & Rarities 1992-2005 - 01 - Freaks On Hubbard (Dave Clarke Remix) (2006/Belgium) [MM129B]  216kbps  m:2016-09-14 08:06:09  a:2016-09-14 08:06:09 relaxed:$mood_relaxed
Dave Clarke - Remixes & Rarities 1992-2005 - 02 - Cars (Dave Clarke Remix) (2006/Belgium) [MM129A]  223kbps  m:2016-09-14 08:06:06  a:2016-09-14 08:06:06 relaxed:$mood_relaxed
Dave Clarke - Remixes & Rarities 1992-2005 - 02 - Lie To Me (Dave Clarke Remix) (2006/Belgium) [MM129B]  201kbps  m:2016-09-14 10:38:17  a:2016-09-14 08:06:09 relaxed:$mood_relaxed
Dave Clarke - Remixes & Rarities 1992-2005 - 03 - Road Tour (Dave Clarke Remix) (2006/Belgium) [MM129A]  229kbps  m:2016-09-14 08:06:06  a:2016-09-14 08:06:06 relaxed:$mood_relaxed
Dave Clarke - Remixes & Rarities 1992-2005 - 03 - La La Land (Dave Clarke Remix) (2006/Belgium) [MM129B]  209kbps  m:2016-09-14 08:09:31  a:2016-09-14 08:06:09 relaxed:$mood_relaxed


$ beet ls -a 'catalognum::MM129.*'
Dave Clarke - 2006 [MM129A] - Remixes & Rarities 1992-2005  a:2016-09-14 08:06:06
Dave Clarke - 2006 [MM129B] - Remixes & Rarities 1992-2005  a:2016-09-14 08:06:09

@JOJ0
Copy link
Member Author

JOJ0 commented Feb 22, 2022

And thanks for the issue link, I just had the idea that in my case taking the catalognumber into account with dup finding would have helped. Awesome you are working on a configurable solution already! :-)

@JOJ0 JOJ0 closed this as completed Feb 22, 2022
@JOJ0
Copy link
Member Author

JOJ0 commented Nov 3, 2022

Just here to say thanks: The feature in the linked PR that was recently merged, fixes exactly the problem I had with this "3 vionyl split" album/release.

Adding this to config now does the trick:

import:
    album: albumartist album catalognum
    item: artist title catalognum

MM129A, MM129B and MM129C are now imported as separate albums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature."
Projects
None yet
Development

No branches or pull requests

2 participants