Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade to click 8 #85

Closed
wichert opened this issue Jan 2, 2023 · 6 comments
Closed

Please upgrade to click 8 #85

wichert opened this issue Jan 2, 2023 · 6 comments

Comments

@wichert
Copy link

wichert commented Jan 2, 2023

aws-sso-util uses click v7. This is not compatible with black, which requires click v8. This is a bit problematic for me since I'm working on a package that calls into some aws-sso-util cli internals (get_token_fetcher in particular), and I can't run black to enforce consistent coding style due to this conflict.

@Almenon
Copy link

Almenon commented Jan 5, 2023

Seconding this, to be honest I don't really care about linting styles but black is great because the autofix allows you to never worry about linting. I configure VSCode to automatically run black on save - it's saved me a lot of time.

@jorenverspeurt
Copy link

Seconding (thirding?) this. Black is so widely used that by depending on the old click version you're severely limiting the environments this library can be installed in.

@benkehoe
Copy link
Owner

benkehoe commented Jan 25, 2023

Things have been going slower this month for me than I planned, but I will have it this week. However, I'm interested in your (@wichert @Almenon @jorenverspeurt) usage of aws-sso-util as a library. aws-sso-util is intended to be installed as a standalone CLI utility (e.g., through pipx); all library use cases are supposed to be supported through aws-sso-lib, which doesn't use click at all. As an example, get_token_fetcher() is in aws_sso_lib.sso, it's not actually in the aws-sso-util code at all.

@wichert
Copy link
Author

wichert commented Jan 25, 2023

After some recent refactoring we still have a dependency on aws-sso-util to have aws-sso-util credential-process available for use in profile configuration.

@benkehoe
Copy link
Owner

Are you sure you still need aws-sso-util credential-process? Almost all the language SDKs support SSO configuration now.

I haven't touched the standalone credential process I made since I folded it into aws-sso-util but it might still work and doesn't use click: https://github.com/benkehoe/aws-sso-credential-process

@benkehoe
Copy link
Owner

Released in aws-sso-util v4.31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants