Catch OSError as well as ValueError on race condition #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
bike-shedding spotted, but can you split it in 2 commit? One for the PEP8 fix and the other for the exception clause? |
|
otherwise the patch is OK for me. |
The fix for issue #863 was incomplete as both OSError or ValueError could be raised by os.fstat(). Thus we need to catch both types of exceptions
|
@benoitc done |
berkerpeksag
added a commit
that referenced
this pull request
Jun 22, 2015
Catch OSError as well as ValueError on race condition
|
Thanks! |
|
Thanks for merging this in so promptly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for issue #863 was incomplete as both OSError or ValueError could be
raised by os.fstat(). Thus we need to catch both types of exceptions
Additionally fixed some PEP8 formatting issues.