add support for gevent on python3 #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitc
added a commit
that referenced
this pull request
Jul 4, 2015
add support for gevent on python3
cpennington
added a commit
to cpennington/course-discovery
that referenced
this pull request
Nov 19, 2015
This requires using a specific version of gunicorn, in which benoitc/gunicorn#1066 has been merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python3 gevent (1.1a1) we have different socket interface, which does not have _sock method.
It's compatible with python standard library socket and have just fileno param.
Here's the socket for python3 code in gevent repo - https://github.com/gevent/gevent/blob/dedb08cf210ebae1ac059150a05542a10d285926/gevent/_socket3.py#L35