Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation of graceful_timeout #1137

Merged
merged 1 commit into from
Nov 2, 2015

Conversation

abesto
Copy link
Contributor

@abesto abesto commented Oct 30, 2015

No description provided.

Generally set to thirty seconds. How max time worker can handle
request after got restart signal. If the time is up worker will
be force killed.
Generally set to thirty seconds. After reciving a restart signal,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: reciving -> receiving

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh. Thanks!

@abesto abesto force-pushed the doc/graceful_timeout branch from 6b8b32f to 4f17ae7 Compare October 30, 2015 17:25
Generally set to thirty seconds. How max time worker can handle
request after got restart signal. If the time is up worker will
be force killed.
Generally set to thirty seconds. After receiving a restart signal,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this first sentence. It repeats information that is already above, in the default value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

@abesto abesto force-pushed the doc/graceful_timeout branch from 4f17ae7 to f1bb034 Compare November 2, 2015 07:49
berkerpeksag added a commit that referenced this pull request Nov 2, 2015
Clarify documentation of graceful_timeout
@berkerpeksag berkerpeksag merged commit eb29a44 into benoitc:master Nov 2, 2015
@berkerpeksag
Copy link
Collaborator

Thanks!

mjjbell pushed a commit to mjjbell/gunicorn that referenced this pull request Mar 16, 2018
Clarify documentation of graceful_timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants