-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify documentation of graceful_timeout #1137
Conversation
Generally set to thirty seconds. How max time worker can handle | ||
request after got restart signal. If the time is up worker will | ||
be force killed. | ||
Generally set to thirty seconds. After reciving a restart signal, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: reciving -> receiving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meh. Thanks!
6b8b32f
to
4f17ae7
Compare
Generally set to thirty seconds. How max time worker can handle | ||
request after got restart signal. If the time is up worker will | ||
be force killed. | ||
Generally set to thirty seconds. After receiving a restart signal, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove this first sentence. It repeats information that is already above, in the default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point!
4f17ae7
to
f1bb034
Compare
Clarify documentation of graceful_timeout
Thanks! |
Clarify documentation of graceful_timeout
No description provided.