Skip to content
This repository has been archived by the owner on Jun 11, 2021. It is now read-only.

Why dependency on @angular/material? #9

Open
Devqon opened this issue Sep 7, 2017 · 4 comments
Open

Why dependency on @angular/material? #9

Devqon opened this issue Sep 7, 2017 · 4 comments

Comments

@Devqon
Copy link

Devqon commented Sep 7, 2017

I had some errors after including the Ng2ImageGalleryModule dependency. It turned out it has a dependency on angular/material, which I hadn't install.

After installing the angular/material the import succeeded.

Also, including the scss file triggers some errors about fontawesome. Instead I included the css in the styles section of .angular-cli.json, which after it worked.

@elessariel
Copy link

seconded. Can't see the reason to pull in angular material atm. could you elaborate?

@Devqon
Copy link
Author

Devqon commented Sep 25, 2017

@elessariel that is what I meant. I also wouldn't think that a dependency on angular/material would be necessary, but if you look at the package.json you can see it's there

@bergben
Copy link
Owner

bergben commented Oct 1, 2017

Hey guys. Sorry for the late response, I was on vacation. Anyhow, the dependency on Angular Material is required because of the displacer-component, which takes the image gallery popup and attaches it directly to the body to make 100% sure that it will appear on top of the other content. See https://github.com/bergben/ng2-image-gallery/blob/master/src/ng2-image-gallery-displacer.component.ts#L14

Suggestions for alternative ways of doing this are highly appreciated, or even more so PRs :)

@ValentinFunk
Copy link

ValentinFunk commented Jul 25, 2018

@bergben i think this stuff is now in @angular/cdk

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants