Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab complete and command history in terminal #1890

Closed
connorbybee opened this issue Oct 8, 2020 · 5 comments · Fixed by #1908
Closed

Tab complete and command history in terminal #1890

connorbybee opened this issue Oct 8, 2020 · 5 comments · Fixed by #1908
Assignees
Labels

Comments

@connorbybee
Copy link

It appears the tab completion and command history options in terminal are not enabled in biology.datahub or datahub. In biology.datahub, those features were working until today.

@d-alex-hughes
Copy link
Collaborator

@connorbybee which shell are you in?

I'm sorry that I'm not on the biology.datahub, but I've seen this issue previously when there has been a change from bash away to another shell as the default.

To get to a bash shell, issue bash at the CLI prompt.

@felder felder self-assigned this Oct 13, 2020
@felder felder added the support label Oct 13, 2020
@felder
Copy link
Contributor

felder commented Oct 13, 2020

@connorbybee

@d-alex-hughes is correct.


$ TABTAB
$ bash
jovyan@jupyter-felder:~$ lsTABTAB
ls           lsblk        lscpu        lslocks      lsm2bin      lsns
lsattr       lsb_release  lsipc        lslogins     lsmem        lspgpot
jovyan@jupyter-felder:~$

@yuvipanda is this something that would make sense to fix? When looking into it I came across https://discourse.jupyter.org/t/customizing-shell-launched-by-terminal/3412

I noticed that @petersudmant removed jupyter_notebook_config.py from the biology deployment. Additionally, it appears this file may not be being properly deployed for data100. Also the config to set the shell appears to be missing from this file in datahub.

Namely should we make the shell behavior consistent for terminals launched via jupyter across all hubs and standardize on bash or perhaps instruct the terminal to always launch jovyan's/rstudio's shell as defined in /etc/passwd? Alternatively should we do nothing and let people know to manually launch their shell of choice?

@felder
Copy link
Contributor

felder commented Oct 13, 2020

@petersudmant notes that in #1865 @yuvipanda mentioned we should just remove the config.

So it may be that we go with the last option which is do nothing, but even so I think "nothing" in this case should be applied consistently so that users in general get the same default shell regardless of which hub they are working in.

@connorbybee
Copy link
Author

@connorbybee which shell are you in?

I'm sorry that I'm not on the biology.datahub, but I've seen this issue previously when there has been a change from bash away to another shell as the default.

To get to a bash shell, issue bash at the CLI prompt.

Great! I didn't notice bash wasn't default.

yuvipanda referenced this issue in yuvipanda/datahub-old-fork Oct 17, 2020
Was inconsistently set via jupyter_notebook_config.py
in some hubs, and only specific to Jupyter Notebooks. This
sets it more generally, and does it for all hubs.

Fixes #1890
@yuvipanda
Copy link
Contributor

Thanks for opening this, @connorbybee!

#1908 should set this to bash for all hubs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants