-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab complete and command history in terminal #1890
Comments
@connorbybee which shell are you in? I'm sorry that I'm not on the biology.datahub, but I've seen this issue previously when there has been a change from bash away to another shell as the default. To get to a bash shell, issue |
@d-alex-hughes is correct.
@yuvipanda is this something that would make sense to fix? When looking into it I came across https://discourse.jupyter.org/t/customizing-shell-launched-by-terminal/3412 I noticed that @petersudmant removed jupyter_notebook_config.py from the biology deployment. Additionally, it appears this file may not be being properly deployed for data100. Also the config to set the shell appears to be missing from this file in datahub. Namely should we make the shell behavior consistent for terminals launched via jupyter across all hubs and standardize on bash or perhaps instruct the terminal to always launch jovyan's/rstudio's shell as defined in /etc/passwd? Alternatively should we do nothing and let people know to manually launch their shell of choice? |
@petersudmant notes that in #1865 @yuvipanda mentioned we should just remove the config. So it may be that we go with the last option which is do nothing, but even so I think "nothing" in this case should be applied consistently so that users in general get the same default shell regardless of which hub they are working in. |
Great! I didn't notice bash wasn't default. |
Was inconsistently set via jupyter_notebook_config.py in some hubs, and only specific to Jupyter Notebooks. This sets it more generally, and does it for all hubs. Fixes #1890
Thanks for opening this, @connorbybee! #1908 should set this to bash for all hubs... |
It appears the tab completion and command history options in terminal are not enabled in biology.datahub or datahub. In biology.datahub, those features were working until today.
The text was updated successfully, but these errors were encountered: