-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove rails 6 deprecations #624
Conversation
+ Fix tests
@JDrizzy awesome job. |
By the way, I can confirm that this works with our Rails 5.2 in production. Also works after upgrading to Rails 6 in my development environment. |
Does it work with web packer? |
I'm currently using it on a production app with webpacker, but the library's assets are still being provided by sprockets, unfortunately. |
Hi, I'm not sure how to solve the issue. Thanks, |
@Amm1r-IT to use the changes for this PR you can either reference my repository in your gemfile: gem 'best_in_place', github: 'JDrizzy/best_in_place' Or, fork your own copy and reference that instead. Ideally, this PR should be merged so you don't need to complete the above two workarounds but I'm not sure when that will be. |
Thanks man |
What's the status ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍🏿
When this PR is planned to be merged? |
Resolves #623
Resolves #621 & #611