Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rails 6 deprecations #624

Closed
wants to merge 2 commits into from
Closed

Remove rails 6 deprecations #624

wants to merge 2 commits into from

Conversation

JDrizzy
Copy link

@JDrizzy JDrizzy commented Mar 12, 2020

  • Fix rails 6 deprecations
  • Attempt to fix tests
  • Added rails 5.1 & 6 and ruby versions 2.5.7 & 2.6.5 to tests
    • Removed rails 3.2, 4.0 and 4.1

Resolves #623
Resolves #621 & #611

@JDrizzy JDrizzy marked this pull request as ready for review March 29, 2020 08:18
@dirkjonker
Copy link

dirkjonker commented Apr 8, 2020

@JDrizzy awesome job.
To make the tests pass for Rails 4.2 work you probably need to pin rspec-rails to 3.x. and bundler to 1.x.

@dirkjonker
Copy link

By the way, I can confirm that this works with our Rails 5.2 in production. Also works after upgrading to Rails 6 in my development environment.

@evanliewer
Copy link

Does it work with web packer?

@JDrizzy
Copy link
Author

JDrizzy commented Apr 14, 2020

Does it work with web packer?

I'm currently using it on a production app with webpacker, but the library's assets are still being provided by sprockets, unfortunately.

@Amm1r-IT
Copy link

Hi, I'm not sure how to solve the issue.
What should I do to make work with rails 6? someone gave me the link to this page but what steps should I take or follow. Any tips?

Thanks,

@JDrizzy
Copy link
Author

JDrizzy commented Apr 16, 2020

@Amm1r-IT to use the changes for this PR you can either reference my repository in your gemfile:

gem 'best_in_place', github: 'JDrizzy/best_in_place'

Or, fork your own copy and reference that instead.

Ideally, this PR should be merged so you don't need to complete the above two workarounds but I'm not sure when that will be.

@Amm1r-IT
Copy link

Amm1r-IT commented Apr 20, 2020

Thanks man

@dsounded
Copy link

What's the status ?

Copy link

@ArturDatsenko ArturDatsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍🏿

@ArturDatsenko
Copy link

When this PR is planned to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails 6 deprecation warning Rails 6 Deprecation warning
7 participants