-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Pages Deploy Plugin #39
Comments
Continued here: #385 |
I'll take the combination of @sergeylukin and my script and make it a plugin. Please send me link on how I write a plugin that extends the |
Sounds like a good plan:) I think at least 1 config variable should be available: branch name. That's because Github use "gh-pages" branch for project repos and "master" branch for user/organization repos. |
Alright I've created https://github.com/docpad/docpad-plugin-ghpages and given you both push + pull access. It appears however that the |
Okay it seems the issue is that the plugins are not loaded at the time that event is fired. Looking into it, it is due to the For now, just make that |
Cool. I like how that works, looking at your template. So everything that has to happen can boil down to:
1 is covered via Two options:
Preferences? |
Separately: if we have direct push/pull access on the repo, would you prefer a separate repo deitch/docpad-plugin-ghpages and I issue a pull request to it and then pull, or that I work directly against docpad/docpad-plugin-ghpages ? |
Regarding git stuff I was thinking about something like that:
What do you think? |
Heh, I just finished writing something almost exactly like that! :-) Along with README.md, etc. Except that getting the remote_repo that way doesn't work, since exec() returns the child_process, not the output of stdout. Hold on, I will push the interim changes out to the repo that @balupton just gave us access to, we can both work from there. |
Huh! I try, but github isn't accepting my push. In the repo page on the Web, I see the URLs show
Weird? |
Could be that you cloned the HTTPS rather the SSH address |
You're right, I did. But looking at the addresses, it shows R/W for both of them. I'll change it anyways and try. |
Yeah, that did it. Strange how it didn't take it, though. |
BTW, what I pushed to the repo was barely reviewed, more like pseudo-coffee-code than code. Just trying to get it into the hands of the rest here. |
Something strange here. I modified my local install to When I do, I get an error
But I know it is installed locally. I run |
Never mind, my own mistake. Ignore. |
OK, question: you use
How do I make it the equivalent of
But it didn't work, even though opts.environment was undefined. |
Hmm, even stranger. It seems to completely ignore the |
Weird, but I got it. You need to set Now I cannot get it any further without having Also the tests have an empty frame, but are non-existent. |
Nice work! Looks good so far. |
AWESOME. This progressed way fast! I applied some improvements with docpad/docpad-plugin-ghpages@b89c29c so now just to figure out that loading issue! So cool! |
Well, not much point in waiting, is there? Might as well do it while it is fresh in all our minds. |
LOL! "... too scary for the average user... " |
Looking forward to use this plugin on my docpad projects :) |
Alrighty, I've got the necessary changes in DocPad going, just need to do some more testing. Changes here: master...dev-loadearly Note these changes: 070f9b9#L0R5 - initially I'll do this only when |
I came across one issue. If you have the livereload plugin, set |
Hey @balpton, how goes this issue? Happy to have done the work, but want it to benefit. |
Fixed the loading issue, however just got back from holidays so haven't had a chance to push it all up. Will be coming soon. |
Done. v2.0.0 of docpad-plugin-ghpages now out 🍰 Well done everyone! Great team effort :) 👍 |
Awesome @balupton really was a great team effort. Do you need 6.24.0 or higher to use it? |
Yes. |
After a generate has finished, it should wipe the
gh-pages
branch, copy the contents of the originalout
directory into it, add the changes, commit them, and check back to the original branch.The text was updated successfully, but these errors were encountered: