Change scripts block to allow custom attributes #397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, I'll merge it in now. It would be nice if the attrs were a JSON object too but that can come later. |
|
Included in the just released v6.21.4 :) |
balupton
added a commit
that referenced
this pull request
Jan 16, 2013
- v6.21.4 January 16, 2013 - Fixed incorrect meta data parsing for certain files - Closes [issue #394](#394) thanks to [Jose Quesada](https://github.com/quesada) and [Stefan](https://github.com/stegrams) - Scripts and styles blocks now support an `attrs` option string - Closes [pull request #397](#397) thanks to [Alex](https://github.com/amesarosh) - Closes [issue #400](#400) thanks to [edzillion](https://github.com/edzillion)
balupton
added a commit
that referenced
this pull request
Oct 23, 2013
- v6.21.4 January 16, 2013 - Fixed incorrect meta data parsing for certain files - Closes [issue #394](#394) thanks to [Jose Quesada](https://github.com/quesada) and [Stefan](https://github.com/stegrams) - Scripts and styles blocks now support an `attrs` option string - Closes [pull request #397](#397) thanks to [Alex](https://github.com/amesarosh) - Closes [issue #400](#400) thanks to [edzillion](https://github.com/edzillion)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is specifically useful for adding data attributes to the script tags generated by getBlock
Ex:
scripts.add( "/js/require.js", defer: false, attrs: 'data-main="js/main"' )->
<script data-main="js/main" src="/js/require.js"></script>