-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 'utf-8' instead of 'utf8' to be standard compliant. #801
Conversation
Looking through some of the node documentation, there are references to |
we could keep utf8 for IO operations. If we keep So ? |
as a counter example see Express. They use |
👍 |
Use 'utf8' for IO operations but use 'UTF-8' for value of encoding parameters.
like that ? |
Oh, sorry, I was happy with using it everywhere 😀 . I suppose it's up to you and Ben! |
For now, let's keep it for just the charset header 👍 Updating the others would mean we would also have to update https://github.com/bevry/istextorbinary/ in which @RobLoach loves his emoji's :) |
⚡ |
Thanks. |
- v6.63.7 February 21, 2014 - Fixed IE9 and below not understanding the charset we send - Thanks to [Eric Vantillard](https://github.com/evantill) for [issue #801](#801) - Better debugging for invalid watch states - For more information see [issue #792](#792) - Fixed DocPad failing to serve files after the initial generation once the docpad configuration file has been modified - Thanks to [Michael Williams](https://github.com/ahdinosaur) for [issue #811](#811) - Updated dependencies
Thank you. I will test it next week. |
Using 'utf8' is not compatible with some IE versions like IE9 (loading page throw a script error “c00ce56e”).
see this article on invalid charset
also see section "Official name and variants" in wikipedia and http://www.w3.org/International/O-HTTP-charset
note: in html5boilerplate the charset is defined as
utf-8