Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributors tool doesn't escape characters in names properly #1728

Open
alice-i-cecile opened this issue Oct 20, 2024 · 1 comment
Open
Labels
A-Release-Notes C-Bug A problem with the code that runs the site S-Ready-For-Implementation The core questions are answered: just add code
Milestone

Comments

@alice-i-cecile
Copy link
Member

          @TrialDragon:

A note for whomever generates the contributors list for 0.15; for some reason there is a contributor listed as WX\shixi which contains an invalid escape sequence which breaks Zola; you will probably have to delete this entry after the file has been generated. I don't know if it's a bug with the contributor part of the generator tool, or if somehow, at some point, we had a contributor with this name.

bevyengine/bevy@bca228f

I think it's a perfectly valid contributor "name". The tool should take care to escape the string instead?

Originally posted by @teohhanhui in #1650 (comment)

@alice-i-cecile alice-i-cecile added this to the Release v0.15 milestone Oct 20, 2024
@alice-i-cecile alice-i-cecile added C-Bug A problem with the code that runs the site A-Release-Notes S-Ready-For-Implementation The core questions are answered: just add code labels Oct 20, 2024
@doup
Copy link
Contributor

doup commented Oct 20, 2024

Looks like single quotes is a thing in TOML:

Literal strings are surrounded by single quotes. No escaping is performed so what you see is what you get

So, we could change generate-release/src/contributors.rs:52… or maybe use serde to serialize?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Release-Notes C-Bug A problem with the code that runs the site S-Ready-For-Implementation The core questions are answered: just add code
Projects
None yet
Development

No branches or pull requests

2 participants