From 6dbc8b8f6f3a97cd928c9dda23f62d19187a669f Mon Sep 17 00:00:00 2001
From: radiish <cb.setho@gmail.com>
Date: Fri, 26 Jul 2024 00:14:16 +0100
Subject: [PATCH] `ptr`: allow `Ptr` and `PtrMut` construction for references
 to values of `?Sized` types (#14479)

# Objective

- Currently `bevy_ptr::{Ptr, PtrMut}` have `From` implementations from
references.
- These implementations impose an implicit `Sized` bound so `bevy_ptr`
types cannot be created from references to slices and trait objects.
- I ran into this trying to use `Ptr<'static>` as an untyped `&'static
dyn Any`, and [had to work around
it](https://github.com/soqb/perfect-reflect/blob/f32b41512c77ad2d7e0f126b0a0fdf388e3e4717/src/registry.rs#L214-L219).

## Solution

- Relax the `Sized` bound on the relevant `From` implementations.
---
 crates/bevy_ptr/src/lib.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/crates/bevy_ptr/src/lib.rs b/crates/bevy_ptr/src/lib.rs
index 51be4dff1e806..5010c931355b5 100644
--- a/crates/bevy_ptr/src/lib.rs
+++ b/crates/bevy_ptr/src/lib.rs
@@ -314,7 +314,7 @@ impl<'a, A: IsAligned> Ptr<'a, A> {
     }
 }
 
-impl<'a, T> From<&'a T> for Ptr<'a> {
+impl<'a, T: ?Sized> From<&'a T> for Ptr<'a> {
     #[inline]
     fn from(val: &'a T) -> Self {
         // SAFETY: The returned pointer has the same lifetime as the passed reference.
@@ -384,7 +384,7 @@ impl<'a, A: IsAligned> PtrMut<'a, A> {
     }
 }
 
-impl<'a, T> From<&'a mut T> for PtrMut<'a> {
+impl<'a, T: ?Sized> From<&'a mut T> for PtrMut<'a> {
     #[inline]
     fn from(val: &'a mut T) -> Self {
         // SAFETY: The returned pointer has the same lifetime as the passed reference.