Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextBundle should derive Clone #15668

Closed
Jaso333 opened this issue Oct 5, 2024 · 4 comments
Closed

TextBundle should derive Clone #15668

Jaso333 opened this issue Oct 5, 2024 · 4 comments
Labels
A-Text Rendering and layout for characters C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Controversial There is active debate or serious implications around merging this PR

Comments

@Jaso333
Copy link

Jaso333 commented Oct 5, 2024

What problem does this solve or what need does it fill?

Being able to use preconfigured bundles as templates is something that I find very useful for flexible entity spawning strategies. In all cases so far, I havent had an issue calling clone on any bundle, but for some reason TextBundle does not drive Clone. This makes it difficult to provide a preconfigured template bundle for re-use.

What solution would you like?

Simply derive(Clone) on TextBundle.

What alternative(s) have you considered?

N/A

Additional context

N/A

@Jaso333 Jaso333 added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Oct 5, 2024
@pablo-lua pablo-lua added C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! D-Straightforward Simple bug fixes and API improvements, docs, test and examples A-Text Rendering and layout for characters and removed C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Oct 5, 2024
@ItsDoot ItsDoot added X-Controversial There is active debate or serious implications around merging this PR A-Text Rendering and layout for characters and removed A-Text Rendering and layout for characters labels Oct 5, 2024
@ItsDoot
Copy link
Contributor

ItsDoot commented Oct 5, 2024

Bevy is moving away from Bundle structs as the primary tool for inserting multiple things at once onto an entity, replacing it with "Required Components". See here for more information: #14791

@Jaso333
Copy link
Author

Jaso333 commented Oct 5, 2024

Bevy is moving away from Bundle structs as the primary tool for inserting multiple things at once onto an entity, replacing it with "Required Components". See here for more information: #14791

Fair enough, but I do understand that Required Components are not immediately replacing the built-in bundles.

@arovge
Copy link

arovge commented Oct 7, 2024

It's true that built-in bundles will only be deprecated in 0.15, but it looks like TextBundle will be removed with the text rework: #15591

I think I read it's likely the text rework lands in time for 0.15, but others closer to the work can confirm that. I'm not familiar enough with the new text design to know if it helps address your issue - hopefully it does!

@VitalyAnkh
Copy link
Contributor

We could close this since TextBundle is deprecated with #15591 in Bevy 0.15 and Text has derived Clone.

@VitalyAnkh VitalyAnkh closed this as not planned Won't fix, can't repro, duplicate, stale Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Text Rendering and layout for characters C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Development

No branches or pull requests

5 participants