Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using aHash where it makes sense. #157

Closed
GabCampbell opened this issue Aug 13, 2020 · 2 comments
Closed

Start using aHash where it makes sense. #157

GabCampbell opened this issue Aug 13, 2020 · 2 comments
Labels
C-Performance A change motivated by improving speed, memory usage or compile times D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@GabCampbell
Copy link
Contributor

There are performance benefits to using aHash over FNVHash. It would be interesting to find out where we can have significant gains and make the necessary changes.
@GabCampbell GabCampbell added D-Trivial Nice and easy! A great choice to get started with Bevy C-Performance A change motivated by improving speed, memory usage or compile times labels Aug 13, 2020
This was referenced Aug 15, 2020
Closed
Closed
@RobDavenport RobDavenport mentioned this issue Aug 20, 2020
Merged
@denismaxim0v
Copy link

I could probably take a look with some guidance if that's still valid

@cart
Copy link
Member

cart commented Nov 2, 2020

#258 largely solved this. There might be a few cases we missed, but I'm comfortable closing this out. If you can find missed cases feel free to open a pr.

@cart cart closed this as completed Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Performance A change motivated by improving speed, memory usage or compile times D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cart @denismaxim0v @GabCampbell