Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frame count to logging #193

Closed
aclysma opened this issue Aug 15, 2020 · 6 comments
Closed

Add frame count to logging #193

aclysma opened this issue Aug 15, 2020 · 6 comments
Labels
C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@aclysma
Copy link
Contributor

aclysma commented Aug 15, 2020

Sometimes frame count can be a useful debug tool. It can help line information up from other sources:

  • Logs
  • Screenshots/Video
  • External tools like renderdoc and profilers

Other helpful fields:

  • Thread ID
  • Posix time (for networking)
  • Millisecond resolution

I guess logging is kind of up to the end-user's application to setup so potentially the outcome of this bug is to verify that the necessary hooks to get this kind of information is available and to document how to do it. Possibly also add it to examples.

@cart cart added C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy labels Aug 15, 2020
@Xavientois
Copy link
Contributor

Would this make sense to create a plugin for? Like, the plugin would count frames (along with those other fields) and be accessible as a resource?

@JayHelton
Copy link

Is this still available to work on?

If so, @cart are you open to giving advice on where to start for hacking away at this? I do think a plugin sounds like a good idea

@cart
Copy link
Member

cart commented Sep 13, 2020

I think it makes sense to add frame count as another diagnostic. We can probably just add it to the current FrameTimePlugin for simplicity.

@cart
Copy link
Member

cart commented Sep 13, 2020

Definitely feel free to work on this!

@mkhan45
Copy link
Contributor

mkhan45 commented Nov 9, 2020

Should this issue be closed?

@cart
Copy link
Member

cart commented Nov 9, 2020

Yup! Thanks for helping us keep the issue tracker clean :)

@cart cart closed this as completed Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Development

No branches or pull requests

5 participants