Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SystemDescriptor does not implement IntoSystemDescriptor #2716

Closed
alice-i-cecile opened this issue Aug 23, 2021 · 0 comments
Closed

SystemDescriptor does not implement IntoSystemDescriptor #2716

alice-i-cecile opened this issue Aug 23, 2021 · 0 comments
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@alice-i-cecile
Copy link
Member

alice-i-cecile commented Aug 23, 2021

What problem does this solve or what need does it fill?

SystemDescriptor does not implement the IntoSystemDescriptor.

This limits our ability to operate on system descriptors generically, as this trait is only implemented for the earlier steps in the data transformation process. This is particularly rough as no other shared representation of parallel and exclusive system descriptors exists.

Random thing I stumbled upon: SystemDescriptor does not implement IntoSystemDescriptor. This prevents being "generic" over parallel/exclusive systems when shoving around whole descriptors instead of descriptors pre-shredded via the type system

  • Ratysz's original description

What solution would you like?

Implement the trait for SystemDescriptor. This should be trivial, as the trait's into_descriptor method just needs to return itself.

What alternative(s) have you considered?

None.

Additional context

Created for @Ratysz, who discovered this issue.

@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events labels Aug 23, 2021
@bors bors bot closed this as completed in 47ccebf Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant