Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per entity texture modifications #2734

Closed
JMS55 opened this issue Aug 26, 2021 · 5 comments
Closed

Per entity texture modifications #2734

JMS55 opened this issue Aug 26, 2021 · 5 comments
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible S-Needs-Design This issue requires design work to think about how it would best be accomplished

Comments

@JMS55
Copy link
Contributor

JMS55 commented Aug 26, 2021

What problem does this solve or what need does it fill?

Currently, there's no easy way to set the opacity of one entity's sprite.

What alternative(s) have you considered?

Modifying the texture directly would modify it for all entities sharing that texture.

@JMS55 JMS55 added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Aug 26, 2021
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen S-Needs-Design This issue requires design work to think about how it would best be accomplished and removed S-Needs-Triage This issue needs to be labelled labels Aug 26, 2021
@VVishion
Copy link
Contributor

Possibly related to #64?
Sorry, if drawing this relation by this comment is unnecessary or they are unrelated.

@mockersf
Copy link
Member

mockersf commented Sep 2, 2021

Entities that share the same handle for a component will all link to the same data underneath, that's the point of handles...

It could be a nice addition to be able to duplicate an handle and get a new handle pointing to the cloned data.

@cart
Copy link
Member

cart commented Sep 4, 2021

Specifically for sprites we have been discussing removing materials and just directly exposing "color" and "texture handle" on the sprite type (or bundle). Not quite sure what we'll land on yet, but I do agree that in the case of sprites, the material abstraction might not be worth it. Currently the new pipelined-rendering branch doesn't use materials for sprites, but I haven't made up my mind yet :)
Curious to hear what everyone else thinks. Godot does "both". Every sprite has a local "color modulation" and "texture handle" value. They can also optionally define "canvas item materials", which can define the color.

@nickfla1
Copy link

nickfla1 commented Oct 4, 2021

I think that the ability to individually set the color or, at least, the alpha component of a sprite without continuously creating new handles would be a really nice addition!

@rparrett
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible S-Needs-Design This issue requires design work to think about how it would best be accomplished
Projects
None yet
Development

No branches or pull requests

7 participants