WindowDescriptor has no effect if resource is inserted after .add_plugins(DefaultPlugins) is called during app construction

[colepoirier]

Bevy version

main as of date of filing (648544f)

Operating system & version

Linux Mint 20.3, X11

What you did

Inserted WindowDescriptor resource after calling .add_plugins(DefaultPlugins).

What you expected to happen

WindowDescriptor to take effect regardless of order of method calls during app construction.

What actually happened

App construction ordering where WindowDescriptor works like you would expect:

use bevy::prelude::*;

fn main() {
    App::new()
        .add_plugins(DefaultPlugins)
        .insert_resource(WindowDescriptor {
            title: "Test Title".to_string(),
            width: 1920.0,
            height: 1080.0,
            ..Default::default()
        })
        .run();
}

App construction ordering where WindowDescriptor does not work like you would expect:

use bevy::prelude::*;

fn main() {
    App::new()
        .insert_resource(WindowDescriptor {
            title: "Test Title".to_string(),
            width: 1920.0,
            height: 1080.0,
            ..Default::default()
        })
        .add_plugins(DefaultPlugins)
        .run();
}

Additional information

Repro repo https://github.com/colepoirier/bevy_app_construction_bug_repro.git, first commit is the working version, second commit is the repro of this app construction ordering bug.

Related to #1255

[ickk]

related to: #2879

[colepoirier]

related to: #2879

Ah fantastic! Thanks for pointing this out @ickk!

For quick reference it is first mentioned in this comment IIUC: #2879 (comment).

[alice-i-cecile]

Another cursed bug caused by #1255.

[rparrett]

I believe this was fixed by #6336