Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReportExecutionOrderAmbiguities doesn't understand query filters #4877

Closed
SUPERCILEX opened this issue May 31, 2022 · 6 comments
Closed

ReportExecutionOrderAmbiguities doesn't understand query filters #4877

SUPERCILEX opened this issue May 31, 2022 · 6 comments
Assignees
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior

Comments

@SUPERCILEX
Copy link
Contributor

SUPERCILEX commented May 31, 2022

Bevy version

e543941 and 0.7.0

What you did

Index: examples/ecs/ecs_guide.rs
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/examples/ecs/ecs_guide.rs b/examples/ecs/ecs_guide.rs
--- a/examples/ecs/ecs_guide.rs	(revision 314e1b7ed6ceff35dd26f90c66b59d5f908e121f)
+++ b/examples/ecs/ecs_guide.rs	(date 1653960365357)
@@ -336,5 +336,17 @@
         .add_plugin(LogPlugin::default())
         .init_resource::<ReportExecutionOrderAmbiguities>()
         // This call to run() starts the app we just built!
+        .add_system(a)
+        .add_system(b)
         .run();
 }
+
+#[derive(Component)]
+struct A;
+
+#[derive(Component)]
+struct B;
+
+fn a(_q: Query<&mut Transform, (With<A>, Without<B>)>) {}
+
+fn b(_q: Query<&mut Transform, (With<B>, Without<A>)>) {}

What went wrong

A conflict is incorrect reported.

@SUPERCILEX SUPERCILEX added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels May 31, 2022
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events and removed S-Needs-Triage This issue needs to be labelled labels May 31, 2022
@alice-i-cecile alice-i-cecile self-assigned this May 31, 2022
@DJMcNab
Copy link
Member

DJMcNab commented May 31, 2022

master is a significantly outdated branch, which might only be available on really old forks - main should be used instead. Could you mention the exact commit you're testing with?

@SUPERCILEX
Copy link
Contributor Author

Sorry, I meant main.

@SUPERCILEX
Copy link
Contributor Author

SUPERCILEX commented May 31, 2022

Specifically e543941 but this is also a bug on 0.7.0

@alice-i-cecile
Copy link
Member

I discovered this in #4299 as well. My feeling is that we need to do a cleanup pass on our Access code to unify this.

@rparrett
Copy link
Contributor

Is this a duplicate of #4381?

@alice-i-cecile
Copy link
Member

Yep; closing as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

No branches or pull requests

4 participants