Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to glam 0.21.2 #5115

Closed
alice-i-cecile opened this issue Jun 27, 2022 · 2 comments
Closed

Update to glam 0.21.2 #5115

alice-i-cecile opened this issue Jun 27, 2022 · 2 comments
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Dependencies A change to the crates that Bevy depends on D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@alice-i-cecile
Copy link
Member

As @dependabot tried in #5112, this migration should be relatively simple. However, we need to migrate off the deprecated const_vec macros and use the much nicer Vec3::from_array methods instead.

This should be nice and simple, but is too hard for a little robot.

@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Dependencies A change to the crates that Bevy depends on A-Math Fundamental domain-agnostic mathematical operations labels Jun 27, 2022
@alice-i-cecile alice-i-cecile changed the title Update to glam0.21.2 Update to glam 0.21.2 Jun 27, 2022
@james7132
Copy link
Member

I think hexasphere needs to be updated too

@bitshifter
Copy link
Contributor

I think it's failing due to the encase dependency which will need to be updated first - https://github.com/bevyengine/bevy/runs/7067058036?check_suite_focus=true.

Also Vec3::new and Vec3::splat are const fn as well so there are a few options for moving off the macros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Dependencies A change to the crates that Bevy depends on D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Development

No branches or pull requests

3 participants