Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split short name functionality into standalone crate #5177

Open
alice-i-cecile opened this issue Jul 2, 2022 · 0 comments
Open

Split short name functionality into standalone crate #5177

alice-i-cecile opened this issue Jul 2, 2022 · 0 comments
Labels
A-Utils Utility functions and types C-Code-Quality A section of code that is hard to understand or change X-Controversial There is active debate or serious implications around merging this PR

Comments

@alice-i-cecile
Copy link
Member

I was wondering whether the new dependency edge from bevy_utils to bevy_reflect would have a negative impact on compilation time. Looking at the output of cargo build --timing, it currently does not, as bevy_reflect is bottlenecked by syn->serde->glam.

image


Alternatively this could go into an entirely different crate. Which is what I needed a while ago for bevy_mod_debugdump so I put the function into a small crate pretty-type-name. We could just use that, unless we want to keep the non-bevy-maintained dependency count low.

Originally posted by @jakobhellermann in #5174 (comment)

bevy_utils is a hodge podge, and this type name parsing functionality is generally useful.

We should consider splitting this functionality out into a small crate under the Bevy org, so it can be easily used in other projects.

This functionality is likely to be extremely stable and has little value to the average Bevy end user, so it does not need to live in the monorepo.

@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change A-Utils Utility functions and types X-Controversial There is active debate or serious implications around merging this PR labels Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Utils Utility functions and types C-Code-Quality A section of code that is hard to understand or change X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Development

No branches or pull requests

1 participant