Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not suffix methods with _component and _resource in reflected types. #5202

Closed
Shatur opened this issue Jul 4, 2022 · 3 comments
Closed

Do not suffix methods with _component and _resource in reflected types. #5202

Shatur opened this issue Jul 4, 2022 · 3 comments
Labels
A-Reflection Runtime information about types C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@Shatur
Copy link
Contributor

Shatur commented Jul 4, 2022 •
edited
Loading

What problem does this solve or what need does it fill?

All methods in ReflectComponent and ReflectResource end with _component and _resource respectively. I think this is redundant and not very consistent with the rest of the API in the engine.

What solution would you like?

Remove _component and _resource suffixes in ReflectComponent and ReflectResource.
@Shatur Shatur added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Jul 4, 2022
@Shatur Shatur mentioned this issue Jul 4, 2022
Closed
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types and removed C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Jul 4, 2022
@oliverpauffley
Copy link
Contributor

This sounds like a good first issue for me to learn how the process works. So I will pick this one up if that's ok!

@Shatur
Copy link
Contributor Author

Shatur commented Jul 4, 2022

@oliverpauffley feel free to take it!

@oliverpauffley oliverpauffley mentioned this issue Jul 5, 2022
Closed
@Shatur
Copy link
Contributor Author

Shatur commented Jul 6, 2022

Closed by #5219.

@Shatur Shatur closed this as completed Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - remove component and resource suffixes from reflect structs oliverpauffley/bevy
3 participants
@alice-i-cecile @oliverpauffley @Shatur