Prevent setting the repeat time on times to zero

[alice-i-cecile]

          I would prefer to make the issue impossible by types, as this means the check will happen several times. Someone doing lots of timers and calling `percent` on every frame may notice an impact... but we can revisit that then

Originally posted by @mockersf in #8467 (review)

[Connor-McMillin]

Should this be a compile time check or a runtime check? I think either way it should be possible to make a NonZeroDuration to hold this logic

[alice-i-cecile]

Ideally compile time :)

[Connor-McMillin]

Here are two possible ways of solving the problem. In my opinion the compile time check is way too hacky to merge, but I thought I would throw it out there in case anyone has a clever way to resolve my hack and make compile time checks actually work. However I think that the runtime check is a net improvement. It does move the problem to NonZeroDuration construction, but it ensures that we do not continually check for zero duration in tick() and percent

[Connor-McMillin]

Its also probably worth discussing what the default Duration should be in NonZeroDuration

[Connor-McMillin]

@alice-i-cecile / @mockersf what are your thoughts on the runtime check PR?

[alice-i-cecile]

Yeah, lemme do a review!