Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

render::primitive::Plane is confusing #8730

Closed
nicopap opened this issue May 31, 2023 · 2 comments · Fixed by #8744
Closed

render::primitive::Plane is confusing #8730

nicopap opened this issue May 31, 2023 · 2 comments · Fixed by #8744
Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@nicopap
Copy link
Contributor

nicopap commented May 31, 2023

How can Bevy's documentation be improved?

render::primitive::Plane is used mostly for frustum culling.

It is used as a half-space (discriminate between two sides of a plane in 3d space) to find which sector of a frustum we are in , and I think it should be renamed to HalfSpace, especially given we already have a shape::Plane that has nothing to do with it.
@nicopap nicopap added C-Docs An addition or correction to our documentation A-Rendering Drawing game state to the screen labels May 31, 2023
@525c1e21-bd67-4735-ac99-b4b0e5262290
Copy link
Contributor

👍

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy labels May 31, 2023
@alice-i-cecile
Copy link
Member

Agreed here :)

@hate hate mentioned this issue Jun 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename Plane struct to HalfSpace
3 participants
@525c1e21-bd67-4735-ac99-b4b0e5262290 @alice-i-cecile @nicopap