Fix NameError when displaying error messages for timed-out commands. #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm running into this ... please pull 👍 |
|
Thanks for helping out. Sorry it's taken me so long to get back into the PRs! |
bflad
added a commit
that referenced
this pull request
Jun 24, 2014
…ages Fix NameError when displaying error messages for timed-out commands.
bflad
added a commit
that referenced
this pull request
Jun 24, 2014
bflad
added a commit
that referenced
this pull request
Jun 24, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #158 by @vblessing, when a subcommand times-out (which is too often to my taste) we get a
NameErrorinstead of the expected error message. The same problem happens for both image, registry and container providers due to code duplication. This modest (and untested) PR should fix it.