Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for LDAP configuration #40

Closed
adamcstephens opened this issue Jul 30, 2015 · 4 comments
Closed

Support for LDAP configuration #40

adamcstephens opened this issue Jul 30, 2015 · 4 comments

Comments

@adamcstephens
Copy link
Contributor

Grafana 2.1 adds LDAP support. Unfortunately, this separate config file is written in TOML which looks to be non-trivial to template. I've stubbed out an example that dumps a config hash into TOML, but it requires the toml gem to be installed. In a master setup, this would require the toml gem to be installed in the puppetserver (puppetserver gem install toml). This is only required if you're using the LDAP config hash.

Thoughts on this? I can put the PR together, but wanted to put this out there before getting everything put together.

@bfraser
Copy link
Owner

bfraser commented Aug 7, 2015

HI @adamcstephens thanks for your contribution!

This looks good, however I do not have LDAP infrastructure to test with. I have applied the configuration as per the documentation, I can see both the main Grafana configuration and the LDAP configuration being built, however grafana-server will not start for me.

In checking the log, it looks like Grafana is attempting to use the LDAP configuration as I can see it complaining about the bind_dn option missing from the config file. This would lead me to believe that the configuration should work, but again I can't easily test.

Has this code been tested with a real LDAP implementation, and do we know for certain that it works?

@adamcstephens
Copy link
Contributor Author

We am using this in production with our fork. I've updated the README to reflect the needed bind_dn and bind_password, even though the upstream Grafana docs say its not necessary. (We are using them)

@bfraser
Copy link
Owner

bfraser commented Aug 7, 2015

Excellent, thank you.

I do see mention in the documentation that Grafana expects a bind DN and password to be supplied.

"By default the configuration expects you to specify a bind DN and bind password. This should be a read only user that can perform ldap searches. When the user DN is found a second bind is performed with the user provided username & password (in the normal Grafana login form)."

I will go ahead and merge. Thanks again!

@bfraser
Copy link
Owner

bfraser commented Aug 7, 2015

fulfilled by #43

@bfraser bfraser closed this as completed Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants