Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instances of monoid-subclasses? #40

Open
blamario opened this issue Jun 2, 2019 · 1 comment
Open

Add instances of monoid-subclasses? #40

blamario opened this issue Jun 2, 2019 · 1 comment

Comments

@blamario
Copy link

blamario commented Jun 2, 2019

Since I fixed issue #24 of monoid-subclasses, the containers' Map and IntMap instances have become less useful. I considered adding instances for MonoidalMap in their place, but monoidal-containers has become a heavy dependency since its addition of aeson.

As an alternative, I wonder if you'd be open to a PR adding the monoid-subclasses as a dependency and the relevant instances? It would bring in only one transitive dependency, namely primes.

@fumieval
Copy link
Contributor

-1 from me. monoid-subclasses seems to be a lot more progressive than monoidal-containers where its sole purpose is to provide a different definition of the Semigroup instance, so I think it should be the other way around.

I believe the plan is to switch to indexed-traversable, which reduces the dependency footprint a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants